Skip to content

check parser_dates names in columns #31815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 251 commits into from
Closed

check parser_dates names in columns #31815

wants to merge 251 commits into from

Conversation

sathyz
Copy link
Contributor

@sathyz sathyz commented Feb 9, 2020

if column names are passed in parser_dates, make sure those
columns exist in dataframe.

@sathyz sathyz requested a review from ShaharNaveh February 9, 2020 02:55
ShaharNaveh
ShaharNaveh suggested changes Feb 9, 2020
View reviewed changes
Copy link
Member

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run "Black" and then push again:)

jbrockmendel and others added 28 commits February 9, 2020 09:58
@jbrockmendel
REF: Remove CategoricalIndex.get_value (pandas-dev#31765)
24d1657
@jbrockmendel
CLN: tests.indexing.common (pandas-dev#31812)
79ca148
@jbrockmendel
REF: tighten what we accept in TimedeltaIndex._simple_new (pandas-dev…
c988567 
…#31315)
@jbrockmendel
CLN: misplaced TimedeltaIndex tests (pandas-dev#31755)
61034b4
@jbrockmendel
TST: parametrize some indexing tests (pandas-dev#31767)
46a77f6
@jbrockmendel
BUG: iloc setitem with 3d indexer not raising (pandas-dev#31813)
74dad82
@jbrockmendel
BUG: Series[dim3array] failing to raise ValueError for some Index sub…
f7e2b74 
…classes (pandas-dev#31816)
@jbrockmendel
REF: share code for set-like ops in DTI/TDI/PI (pandas-dev#31335)
7d1f825
@jbrockmendel
REF: share _partial_date_slice between PeriodIndex/DatetimeIndex (pan…
08bdf31 
…das-dev#31766)
@jbrockmendel
REF: turn _try_mi into MultiIndex._get_values_for_loc (pandas-dev#31736)
c389222
@jbrockmendel
REF/TST: misplaced tests in tests.indexes.period (pandas-dev#31758)
a8817ba
@jbrockmendel
REF: remove iloc case from _convert_slice_indexer (pandas-dev#31786)
0a52507
@jbrockmendel
DEPR: indexing Series with single-entry list (pandas-dev#31333)
04e9a78
@dsaxton
DOC: Fix style guide typos (pandas-dev#31822)
ccc6923
@topper-123
BUG: Too aggressive typing in NDFrame.align (pandas-dev#31788)
341a719
@rushabh-v
correct the redirections (pandas-dev#31820)
c3a9ea3
@r0cketr1kky
DOC: Removed numeric_only parameter from pd.DataFrame.mad docs (panda…
0aad719 
…s-dev#31641)
@Cardosaum
DOC: '10 minutes to pandas' - <TAB> completion section now show a con… (
a76cfbf 
pandas-dev#31818)
@topper-123
CLN: remove kwargs from signature of (Index|MultiIndex).copy (pandas-…
b30d7d4 
…dev#31669)
@jbrockmendel
REF: use public indexers in groupby.ops (pandas-dev#31814)
8cfcf65
@SaturnFromTitan
fixed mypy errors in mypy-pandas.tests.extension.decimal.test_decimal (…
f04d913 
…pandas-dev#31730)
@raisadz
Test messages test period (pandas-dev#31824)
980ab6b
@jbrockmendel
REF: simplify PeriodIndex.get_loc (pandas-dev#31598)
b42505e
@jbrockmendel
CLN: trim unreachable indexing code (pandas-dev#31768)
c5fb994
@dhirschfeld
Fix bug in calculation of holidays (pandas-dev#31416)
c4e8eb3
@pedroreys
BUG Decode to UTF-8 the dtype string read from a hdf file (pandas-dev…
a96bdbd 
…#31756)
@SaturnFromTitan
fixed mypy errors in pandas.tests.extension.json.test_json (pandas-de…
d2a14ac 
…v#31836)
@charlesdong1991
ENH: Allow multi values for index and columns in df.pivot (pandas-dev…
11f1500 
…#30928)
jbrockmendel and others added 24 commits February 26, 2020 20:44
@jbrockmendel
TST: move misplaced to_datetime test (pandas-dev#32273)
8621970
@jbrockmendel
Troubleshoot CI (pandas-dev#32284)
97c0ce9
@jbrockmendel
test_droplevel (pandas-dev#32272)
eb6f8d3
@jaketae
Use defaultdict for optimization (pandas-dev#32278)
66c6e8e
@jbrockmendel
PERF: pass through to numpy validation for iloc setitem (pandas-dev#3…
922f932 
…2257)
@jbrockmendel
TST: misplaced arithmetic tests (pandas-dev#32275)
736761f
@simonjayhawkins
CLN: Follow-up to pandas-dev#32158 (pandas-dev#32290)
cad3f1c
@jbrockmendel
TST: implement test_first (pandas-dev#32274)
0233a55
@datapythonista
CI: Temporary fix to the docs build while we fix the ssh problems (pa…
674dd69 
…ndas-dev#32279)
@jbrockmendel
TST: test_to_time (pandas-dev#32285)
217a428
@jbrockmendel
implement test_to_period (pandas-dev#32270)
1d18e95
@mankoff
fixed minor docstring typo (pandas-dev#32298)
86f0468
@jbrockmendel
REF/TST: misplaced tests in test_timeseries, test_timezones (pandas-d…
d5d6834 
…ev#32300)
@Samira-g-js
Added in a error message (pandas-dev#32105)
b4cbc19
@ryankarlos
DOC: Add example for multiindex series and dataframe merge (pandas-de…
4800ab4 
…v#32068)
@MarcoGorelli
BUG: fix in categorical merges (pandas-dev#32079)
ea1d8fa
@MarcoGorelli
WEB: Add greeting note to CoC (pandas-dev#32024)
1e7dc49
@jbrockmendel
API/BUG: raise only KeyError failed on geitem/loc lookups (pandas-dev…
5fa9860 
…#31867)
@mroeschke
DOC: Reorder 1.0 releases in whatsnew/index.rst (pandas-dev#32309)
edcf1c8
@sathyz
check parser_dates names in columns
7eb6713 
if column names are passed in parser_dates, make sure those
columns exist in dataframe.
@sathyz
fix lint issue.
5cadb42
@sathyz
validate parse_dates - added nested list case
7fed1ca
@sathyz
format code based on ci checks
999ffc5
@sathyz
Merge remote-tracking branch 'origin/issue-31251-1' into issue-31251-1
5b381e3
This was referenced Feb 28, 2020
Closed
Merged
@jreback jreback added this to the 1.1 milestone Mar 3, 2020
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

closing as duplicate of #32320

@jreback jreback closed this Mar 3, 2020
@sathyz sathyz deleted the issue-31251-1 branch March 3, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung left review comments

@jreback jreback jreback requested changes

@ShaharNaveh ShaharNaveh ShaharNaveh requested changes

@WillAyd WillAyd Awaiting requested review from WillAyd

@jschendel jschendel Awaiting requested review from jschendel

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

read_csv: if parse_dates dont appear in use_cols, we get a trace