REF/TST: misplaced tests in test_timeseries, test_timezones #32300
Conversation
| from pandas import MultiIndex, Timestamp, date_range | ||
|
|
||
|
|
||
| class TestGetLevelValues: |
There was a problem hiding this comment.
This method is also on Index. should the module be just pandas/tests/indexes/test_get_level_values.py
There was a problem hiding this comment.
sorry... pandas/tests/indexes/methods/test_get_level_values.py
There was a problem hiding this comment.
it exists on Index, but is really only relevant for MultiIndex i think
There was a problem hiding this comment.
I appreciate that, but I assume that this reorganization is to aid parametrisation. and that the index tests will be grouped by method instead of Index class?
There was a problem hiding this comment.
the index tests will be grouped by method instead of Index class
I have no plans to do that anytime soon
There was a problem hiding this comment.
fair enough, I suppose that Series and Frame are still separate and that's only two classes. we'll see how the method based testing and parametrisation goes on those.
| assert df["Date"][0] == dates[0][0] | ||
| assert df["Forecasting"][0] == dates[0][1] | ||
|
|
||
| s = Series(arr["Date"]) |
There was a problem hiding this comment.
maybe add a TODO for spliting out the Series test or parameterising.
as an aside where will the Series and Frame tests go. does this need to move again?
There was a problem hiding this comment.
as an aside where will the Series and Frame tests go
For tests like this that are mostly testing Frame with a little bit of Series test on the side, it'll probably stay mixed for the foreseeable future. For tests where we can share/parametrize tests between Series/Frame, maybe tests.generic? (though the tests currently in that directory are not in great shape)
simonjayhawkins
added
Clean
Testing
There was a problem hiding this comment.
Thanks @jbrockmendel
pandas/tests/frame/test_timezones.py, pandas/tests/series/test_timeseries.py and pandas/tests/series/test_timezones.py will eventually disappear?
Seems likely |
No description provided.