TST: implement test_first #32274
Merged
TST: implement test_first #32274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbrockmendel I would love to open a PR parameterising these tests. Choosing a naming convention seems too difficult for me, tbh |
mroeschke
reviewed
Feb 27, 2020
| @@ -0,0 +1,61 @@ | |||
| """ | |||
| Note: includes tests for `last` | |||
There was a problem hiding this comment.
Could we just rename the file test_first_and_last.py?
mroeschke
reviewed
Feb 27, 2020
| @@ -0,0 +1,69 @@ | |||
| """ | |||
There was a problem hiding this comment.
Could we just rename the file test_first_and_last.py?
mroeschke
approved these changes
Feb 27, 2020
simonjayhawkins
added
Clean
Testing
|
Thanks @jbrockmendel I think naming the module test_first as you originally did is more consistent. Maybe we could have a test_last.py file which is just a comment that directs the contributor/reader to test_first.py |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @MomIsBestFriend there are three things about these tests that I think would make for good (separate) follow-ups if you're interested: