Skip to content

CI: Temporary fix to the docs build while we fix the ssh problems #32279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2020
Merged

CI: Temporary fix to the docs build while we fix the ssh problems #32279

merged 1 commit into from
Feb 27, 2020

Conversation

datapythonista
Copy link
Member

Looks like the ssh key we have in the settings is not working as expected in #32074.

While we fix it (I don't have access to the settings, so can't check much), this prevents master from failing for the publishing of the dev docs to GitHub pages.

@datapythonista datapythonista added Docs CI Continuous Integration Web pandas website labels Feb 26, 2020
@jreback
Copy link
Contributor

jreback commented Feb 27, 2020

wait. so the new docs are failing but we didn't notice? just revert #32074

@datapythonista
Copy link
Member Author

I can revert the failing changes, but it'll be hard to fix the problem if we're not trying to push the docs in the CI. The problem is that github secrets can't be accessed from PRs, so we can't test things using secrets before merging.

Not sure why github actions doesn't notify us when a build fails, but that's a good point, I'll open a ticket and investigate.

@jreback
Copy link
Contributor

jreback commented Feb 27, 2020

ok fair

merge away then

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 27, 2020
@simonjayhawkins simonjayhawkins merged commit 674dd69 into pandas-dev:master Feb 27, 2020
@simonjayhawkins
Copy link
Member

Thanks @datapythonista do we need/have an open issue for this?

@simonjayhawkins
Copy link
Member

@datapythonista not sure this is working as intended. revert?

@simonjayhawkins
Copy link
Member

@datapythonista nvm we now have green.

@datapythonista
Copy link
Member Author

Yes, looks like this work as expected. The pushing to GitHub pages still failed, but the CI result is green:

I created #32301 for the problem with the notifications. @jreback feel free to edit if that's not exactly what we should have. I also created #32303 for the original problem with the ssh key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants