Skip to content

CLN: Use defaultdict for minor optimization #32278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2020
Merged

CLN: Use defaultdict for minor optimization #32278

merged 1 commit into from
Feb 27, 2020

Conversation

jaketae
Copy link
Contributor

@jaketae jaketae commented Feb 26, 2020

Edit _from_nested_dict() by using defaultdict for optimization in performance

@jaketae
Copy link
Contributor Author

jaketae commented Feb 26, 2020

@WillAyd @jreback Should this fix the problem? Thanks again for your input, and apologies for achieving this in such a roundabout fashion.

@WillAyd
Copy link
Member

WillAyd commented Feb 27, 2020

Yea we typically ask that you keep updates to the change all in one PR, but OK as is

WillAyd
WillAyd approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm @jreback any objections?

@jreback
Copy link
Contributor

jreback commented Feb 27, 2020

this is ok

pls add labels

@jaketae
Copy link
Contributor Author

jaketae commented Feb 27, 2020

Yea we typically ask that you keep updates to the change all in one PR, but OK as is

@WillAyd I will make sure to follow that guideline for any future PRs. Thanks for the understanding.

@jreback jreback added the Performance Memory or execution speed performance label Feb 27, 2020
@jreback jreback added this to the 1.1 milestone Feb 27, 2020
@jreback jreback merged commit 66c6e8e into pandas-dev:master Feb 27, 2020
@jreback
Copy link
Contributor

jreback commented Feb 27, 2020

thanks @jaketae

@jaketae jaketae deleted the dict-opt branch March 2, 2020 15:34
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@jaketae @roberthdevries
Use defaultdict for optimization (pandas-dev#32278)
ac0ba68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jaketae @WillAyd @jreback