Skip to content

correct redirections in doc/redirect.csv for rolling #31820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2020
Merged

correct redirections in doc/redirect.csv for rolling #31820

merged 1 commit into from
Feb 9, 2020

Conversation

rushabh-v
Copy link
Contributor

@rushabh-v rushabh-v commented Feb 9, 2020 •
edited
Loading

@rushabh-v rushabh-v requested a review from WillAyd February 9, 2020 11:40
@rushabh-v
Copy link
Contributor Author

@WillAyd I tried and found other rolling related links broken too. So, I have changed other rolling related redirections too.

@WillAyd
Copy link
Member

WillAyd commented Feb 9, 2020

Sounds good. Is the sphinx build generating warnings about these links perhaps? Wondering if there is a way to identify more

@jreback jreback added this to the 1.0.2 milestone Feb 9, 2020
@jreback jreback merged commit c3a9ea3 into pandas-dev:master Feb 9, 2020
@jreback
Copy link
Contributor

jreback commented Feb 9, 2020

thanks @rushabh-v

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 9, 2020
@rushabh-v @meeseeksmachine
Backport PR pandas-dev#31820: correct redirections in doc/redirect.cs…
1a8c4e9 
…v for rolling
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 9, 2020
Merged
simonjayhawkins pushed a commit that referenced this pull request Feb 9, 2020
@meeseeksmachine @rushabh-v
Backport PR #31820: correct redirections in doc/redirect.csv for roll…
8dbe672 
…ing (#31826)

Co-authored-by: Rushabh Vasani <[email protected]>
@jorisvandenbossche
Copy link
Member

We also need new redirects from /pandas.core.window.Rolling... to pandas.core.window.rolling.Rolling... to fix the actual issue reported by @WillAyd (so reopened the issue)

@rushabh-v
Copy link
Contributor Author

rushabh-v commented Feb 10, 2020 •
edited
Loading

Sure, will be opening a PR soon :)

@rushabh-v
Copy link
Contributor Author

rushabh-v commented Feb 10, 2020 •
edited
Loading

Sorry @jorisvandenbossche I couldn't figure out what you did mean by,

We also need new redirects from /pandas.core.window.Rolling... to pandas.core.window.rolling.Rolling... to fix the actual issue reported by @WillAyd

Can you please elaborate a bit more?

@jorisvandenbossche
Copy link
Member

@rushabh-v check the two links mentioned y @WillAyd in the original issue: #31762 The first link should redirect to the second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

Rolling Apply Docs Broken
5 participants
@rushabh-v @WillAyd @jreback @jorisvandenbossche @ShaharNaveh