DOC: '10 minutes to pandas' - <TAB> completion section now show a con… #31818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistent block of suggestions. pandas-dev#31526
gfyoung
reviewed
Feb 9, 2020
doc/source/getting_started/10min.rst
Outdated
| @@ -67,20 +67,20 @@ will be completed: | |||
| @verbatim | |||
| In [1]: df2.<TAB> # noqa: E225, E999 | |||
| df2.A df2.bool | |||
| df2.abs df2.boxplot | |||
| df2.abs() df2.boxplot | |||
There was a problem hiding this comment.
I can't check this, but are you sure we actually provide parentheses? That seems inconsistent with the other ones.
There was a problem hiding this comment.
Oh, you are right!
sorry for this mistake.
|
@Cardosaum : First off, welcome to I have a quick question about your changes. Otherwise, would be good if someone else from @pandas-dev/pandas-core could review this, as I can't check this. |
thanks to @gfyoung to spot this error.
|
I corrected this error, @gfyoung . Thanks for spotting this! |
|
thanks @Cardosaum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sistent block of suggestions. Solve issue #31526
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI didn't run those listed tests above, however I doubt it will break something.
This PR only correct a Typo I found on documentation. I hope I'll be useful to improve this project.