CLN: trim unreachable indexing code #31768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Feb 7, 2020
| @@ -1070,7 +1065,7 @@ def _set_with(self, key, value): | |||
|
|
|||
| def _set_labels(self, key, value): | |||
| key = com.asarray_tuplesafe(key) | |||
| indexer = self.index.get_indexer(key) | |||
| indexer: np.ndarray = self.index.get_indexer(key) | |||
There was a problem hiding this comment.
Shouldn't need to annotate like this; if anything should set the return of get_indexer to np.ndarray
There was a problem hiding this comment.
yah, im trying to pin down what gets passed to _set_values below. The check on L1075 is never True, so id like to see if we can rip it out
Yes |
jreback
added
the
Indexing
jreback
requested changes
Feb 9, 2020
| @@ -902,7 +902,7 @@ def _get_with(self, key): | |||
| return self._get_values(key) | |||
| raise | |||
|
|
|||
| if not isinstance(key, (list, np.ndarray, Series, Index)): | |||
| if not isinstance(key, (list, np.ndarray, ExtensionArray, Series, Index)): | |||
There was a problem hiding this comment.
we likely don't have many tests which do this on EAs FYI
| assert res.index[-1] == "foobar" | ||
| assert res._get_value("foobar", "B") == 0 | ||
| float_frame._set_value("foobar", "B", 0) | ||
| assert float_frame.index[-1] == "foobar" |
There was a problem hiding this comment.
you could assert the return value is None
jreback
reviewed
Feb 9, 2020
| assert res is s | ||
| assert res.index[-1] == "foobar" | ||
| assert res["foobar"] == 0 | ||
| s._set_value("foobar", 0) |
There was a problem hiding this comment.
same here, assert return value is None
|
ping |
jreback
approved these changes
Feb 9, 2020
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make _set_value not return anything (the DataFrame docstring in particular is misleading)