Skip to content

CLN: remove kwargs from signature of (Index|MultiIndex).copy #31669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2020
Merged

CLN: remove kwargs from signature of (Index|MultiIndex).copy #31669

merged 2 commits into from
Feb 9, 2020

Conversation

topper-123
Copy link
Contributor

Removes **kwargs from Index.copy and MultiIndex.copy.

@topper-123 topper-123 changed the title CLN: clean signature of (Index|MultiIndex).copy CLN: remove kwargs from signature of (Index|MultiIndex).copy Feb 4, 2020
jbrockmendel
jbrockmendel reviewed Feb 4, 2020
View reviewed changes
pandas/core/indexes/base.py Outdated
"""
Make a copy of this object. Name and dtype sets those attributes on
the new object.

Parameters
----------
name : str, optional
name : Optional[Hashable]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we call this Label (from pandas._typing)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've changed this to Label.

@jreback jreback added Clean Index Related to the Index class or subclasses labels Feb 5, 2020
@jreback jreback added this to the 1.1 milestone Feb 5, 2020
jreback
jreback approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ex- @jbrockmendel comment

@topper-123
Copy link
Contributor Author

Ping. I've rebased just in case.

@jbrockmendel
Copy link
Member

LGTM

@jreback jreback merged commit b30d7d4 into pandas-dev:master Feb 9, 2020
@jreback
Copy link
Contributor

jreback commented Feb 9, 2020

thanks @topper-123

@topper-123 topper-123 deleted the cln_index_copy branch February 12, 2020 21:48
@topper-123 topper-123 mentioned this pull request Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @jbrockmendel @jreback