Skip to content

WEB: Add greeting note to CoC #32024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 15, 2020

I noticed something similar in the CPython contributing docs:

For example, don’t say “hey guys!” but “hey everyone!”.

and thought it was really nice.

Pushing directly rather than opening as good first issue to avoid invoking a s*******m

@simonjayhawkins simonjayhawkins added the Web pandas website label Feb 15, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 15, 2020
@MarcoGorelli MarcoGorelli changed the title hey guys statement WEB: hey everyone Feb 15, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 16, 2020

Should be good - can you merge master to get green?

@WillAyd WillAyd added Docs and removed Web pandas website labels Feb 16, 2020
@@ -42,6 +42,7 @@ If you want to support pandas development, you can find information in the [dona
> or anyone willing to increase the diversity of our team.
> We have identified visible gaps and obstacles in sustaining diversity and inclusion in the open-source communities and we are proactive in increasing
> the diversity of our team.
> We welcome inclusive behavior - for example, please don’t say “hey guys!” but “hey everyone!”.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the team page, doesn't seem relevant to me here. Should it be in the code of conduct instead?

@datapythonista datapythonista added the Web pandas website label Feb 17, 2020
@jorisvandenbossche
Copy link
Member

I agree this feels a bit "out of place" where it is added now

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @MarcoGorelli

@datapythonista
Copy link
Member

If you can merge master, looks like something (I guess unrelated) failed.

@datapythonista datapythonista changed the title WEB: hey everyone WEB: Add greeting note to CoC Feb 26, 2020
@WillAyd WillAyd merged commit 1e7dc49 into pandas-dev:master Feb 27, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 27, 2020

Thanks @MarcoGorelli

roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@MarcoGorelli MarcoGorelli deleted the hey-everyone branch March 26, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants