BUG: iloc setitem with 3d indexer not raising #31813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2020
jreback
added
the
Indexing
jreback
reviewed
Feb 9, 2020
| @@ -1678,6 +1678,10 @@ def _do_convert_missing(self, data: DataFrame, convert_missing: bool) -> DataFra | |||
| missing_value = StataMissingValue(um) | |||
|
|
|||
| loc = missing_loc[umissing_loc == j] | |||
| if loc.ndim == 2 and loc.shape[1] == 1: | |||
There was a problem hiding this comment.
can we make a note to refactor this; this seems a bit fishy; cc @bashtage
|
thanks @jbrockmendel |
bashtage
added a commit
to bashtage/pandas
that referenced
this pull request
Feb 10, 2020
Use nonzero to preserve 1d of Series xref pandas-dev#31813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffalso get the exceptions/messages in test_setitem_ndarray_3d to be maximally-specific