TST: parametrize some indexing tests #31767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ram-scalar-indexing
…ram-scalar-indexing
jreback
added
the
Indexing
jreback
reviewed
Feb 9, 2020
| # on appropriate Index types & accessors | ||
|
|
||
| for index in [ | ||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
eventually consolidate move to top-level (as i suspect we have many of these fixtures, or will as you parametrize)
| "unicode", | ||
| "mixed", | ||
| }: | ||
| # getting |
There was a problem hiding this comment.
obviously this test can use ore parameterization, ok for later
| @@ -9,61 +9,59 @@ | |||
|
|
|||
|
|
|||
| class TestScalar(Base): | |||
| def test_at_and_iat_get(self): | |||
| @pytest.mark.parametrize("kind", ["series", "frame"]) | |||
There was a problem hiding this comment.
make sure we use the same nomenclature, usually we call this klass and use the object itself
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/many