DOC: Removed numeric_only parameter from pd.DataFrame.mad docs #31641
Conversation
r0cketr1kky
commented
Feb 4, 2020
r0cketr1kky
commented
- closes DOC: mad description incorrectly includes 'numeric_only' #29079
r0cketr1kky
changed the title
pandas/core/generic.py
Outdated
| @@ -10315,10 +10315,6 @@ def _doc_parms(cls): | |||
| level : int or level name, default None | |||
| If the axis is a MultiIndex (hierarchical), count along a | |||
| particular level, collapsing into a %(name1)s. | |||
| numeric_only : bool, default None | |||
There was a problem hiding this comment.
Removing this will remove numeric_only for all other statistical function that actually accept numeric_only. We only want to remove this for mad
There was a problem hiding this comment.
Makes sense...I shall correct my mistake. Thank you for guiding me @mroeschke
There was a problem hiding this comment.
Please review this commit!
pandas/core/generic.py
Outdated
| ---------- | ||
| axis : %(axis_descr)s | ||
| Axis for the function to be applied on. | ||
| skipna : bool, default True |
There was a problem hiding this comment.
Thanks @r0cketr1kky
Isn't the default for skipna None rather than True?
def mad(self, axis=None, skipna=None, level=None):
There was a problem hiding this comment.
Yes, you're right. I will change this too.
pandas/core/generic.py
Outdated
| **kwargs | ||
| Additional keyword arguments to be passed to the function. |
There was a problem hiding this comment.
Does this function accept kwargs?
def mad(self, axis=None, skipna=None, level=None):
There was a problem hiding this comment.
No, it doesn't. I will remove this as well.
There was a problem hiding this comment.
I've updated the file. Please review it!
|
Please review this @MarcoGorelli @mroeschke |
|
I think it's fine, could you include a screenshot of the documentation? Inside the |
|
Hi, I'm getting the following error when I run "python make.py clean" |
|
@r0cketr1kky you'll need to build the c extensions: https://pandas-docs.github.io/pandas-docs-travis/development/contributing.html#creating-a-python-environment |
|
Documentation screenshot @MarcoGorelli :
P.S. Thanks for the link @mroeschke . This helped me. |
|
Please review this! |
|
How long does it take to merge this PR? |
|
@r0cketr1kky I don't have write-access to the repo, and I presume that those who do are prioritising other work. Please be patient, I'm pretty sure this will get merged |
|
Sure, thanks a lot for assisting me! |
|
thanks @r0cketr1kky if you'd canvas the other operations that use |
|
Ahh I just saw this comment @jreback I'm having a busy semester :( |
