REF: share code for set-like ops in DTI/TDI/PI #31335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Clean
ExtensionArray
jreback
requested changes
Jan 31, 2020
|
can you merge master here and i'll look again |
jreback
reviewed
Feb 2, 2020
| @@ -697,12 +697,28 @@ def _assert_can_do_setop(self, other): | |||
| if isinstance(other, PeriodIndex) and self.freq != other.freq: | |||
| raise raise_on_incompatible(self, other) | |||
|
|
|||
| def intersection(self, other, sort=False): | |||
| def _setop(self, other, sort, opname: str): | |||
There was a problem hiding this comment.
eventually if you can type / doc-string this
jreback
approved these changes
Feb 2, 2020
|
k some followup requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DatetimeIndexOpsMixin._concat_same_type this has can probably become the ExtensionIndex._concat_same_type default. I expect IntervalIndex can be updated to look the same pretty easily, not so sure about CategoricalIndex based on a quick look.