REF: use public indexers in groupby.ops #31814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 9, 2020
| @@ -780,7 +780,11 @@ def get_iterator(self, data: FrameOrSeries, axis: int = 0): | |||
| Generator yielding sequence of (name, subsetted object) | |||
| for each group | |||
| """ | |||
| slicer = lambda start, edge: data._slice(slice(start, edge), axis=axis) | |||
| if axis == 0: | |||
There was a problem hiding this comment.
a more natural idiom (used in many places is)
indexer = [None] * 2
indexer[axis] = slice(start, edge)
slicer = data.iloc[indexer]
There was a problem hiding this comment.
i guess, but thats not really conducive to being a lambda
There was a problem hiding this comment.
why does this need to be a lamba?
There was a problem hiding this comment.
doesnt have to be, thats just the pattern we have now. i find iloc[:, start:end] clearer than the 3-line version
WillAyd
reviewed
Feb 9, 2020
jreback
approved these changes
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.