BUG Decode to UTF-8 the dtype string read from a hdf file #31756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Feb 6, 2020
Fixes GH31750 The dtype value wasn't being decoded to `UTF-8` when reading a DataFrame from a hdf file. This was a problem when reading a hdf that was created from python 2 with a fixed format as the dtype was being read as `b'datetime'` instead of `datetime`, which caused `HDFStore` to read the data as `int64` instead of coercing it to the correct `datetime64` dtype. move doc to right file
WillAyd
approved these changes
Feb 7, 2020
jreback
approved these changes
Feb 9, 2020
There was a problem hiding this comment.
lgtm. thanks @pedroreys
note this might close some older issues, if you'd have a look. (comment on the issue if this is the case; we might need additional validation tests).
|
thanks |
|
thanks folks |
|
@jreback to get this fix backported to 1.0.2, do I need to open a second PR targeting that branch, or is it going to get picked up automatically by that backport bot? |
|
we don’t backport regular big fixes |
1 similar comment
|
we don’t backport regular big fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH31750
The dtype value wasn't being decoded to
UTF-8when reading a DataFramefrom a hdf file. This was a problem when reading a hdf that was
created from python 2 with a fixed format as the dtype was being read as
b'datetime'instead of
datetime, which causedHDFStoreto read the data asint64instead of coercing it to the correctdatetime64dtype.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff