REF/TST: misplaced tests in tests.indexes.period #31758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Period
jreback
requested changes
Feb 6, 2020
|
|
||
| exp = DatetimeIndex(["2011-01-01", "2011-02-01", "2011-03-01"], tz="US/Eastern") | ||
| res = pi.astype("datetime64[ns, US/Eastern]") | ||
| tm.assert_index_equal(pi.astype("datetime64[ns, US/Eastern]"), exp) |
There was a problem hiding this comment.
the res here is duplicated
also can you have the others use res= rather than doing it in the comparator
| tm.assert_index_equal(pd.Index(arr), pd.PeriodIndex(arr)) | ||
| tm.assert_index_equal(pd.Index(np.array(arr)), pd.PeriodIndex(np.array(arr))) | ||
| arr = [Period("2011-01", freq="M"), NaT, Period("2011-03", freq="M")] | ||
| tm.assert_index_equal(Index(arr), PeriodIndex(arr)) |
There was a problem hiding this comment.
ideally make these
res =
exp =
There was a problem hiding this comment.
agreed. per request from @WillAyd, trying to keep pure-moves separate from other cleanups. dont worry, there's plenty more index test organization on its way
jreback
approved these changes
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.