REF: remove iloc case from _convert_slice_indexer #31786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jreback
added
the
Indexing
|
sure |
1 similar comment
|
sure |
| if kind == "iloc": | ||
| return super()._convert_slice_indexer(key, kind=kind) | ||
|
|
||
| # We always treat __getitem__ slicing as label-based |
There was a problem hiding this comment.
I am not sure this comment is correct? (eg for a series with Int64Index, slicing is positional?)
There was a problem hiding this comment.
this method is for Float64Index
There was a problem hiding this comment.
Ah, missed that in the diff. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_convert_slice_indexer is turning out to be one of the stickier methods to figure out, xref #31658.
The case with kind=None is only called from one place in core.indexing, and that is not reached in the tests. I'd like to either a) figure out a non-None kind to pass to it, or b) determine that it can never be reached so can be removed. Any thoughts on this are very welcome.