REF: tighten what we accept in TimedeltaIndex._simple_new #31315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 26, 2020
pandas/tests/resample/test_base.py
Outdated
| @@ -106,7 +106,9 @@ def test_resample_empty_series(freq, empty_series, resample_method): | |||
| if isinstance(s.index, PeriodIndex): | |||
| expected.index = s.index.asfreq(freq=freq) | |||
| else: | |||
| expected.index = s.index._shallow_copy(freq=freq) | |||
| idx = s.index | |||
There was a problem hiding this comment.
same comment as above, why not just collapse this so: s.index.asfreq(freq=freq) or s.copy()
we don't need to have the shallow copy used like this in tests, nor work-arounds like this.
There was a problem hiding this comment.
implemented a helper _asfreq_compat for this, cleans up some code nicely
jreback
requested changes
Jan 31, 2020
jreback
reviewed
Feb 5, 2020
|
|
||
|
|
||
| def _asfreq_compat(index, freq): | ||
| """ |
There was a problem hiding this comment.
should this be in the indexes sub-tree?
There was a problem hiding this comment.
if we start using it elsewhere then we can move it. as long as its just here, id prefer to keep it private
|
gentle ping, id like to get this one in and move on to the PeriodArray and DTA counterparts |
jreback
approved these changes
Feb 9, 2020
|
thanks |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.