WIP: API: Add support for PEP 519 / file system path protocol #14123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkurDedania
changed the title
AnkurDedania
changed the title
jorisvandenbossche
added
the
IO Data
|
needs tests |
jreback
changed the title
|
@AnkurDedania Do you have time to update this and add tests? |
|
can you rebase / update |
|
TIL how to rebase, if done correctly |
|
It seems the rebase worked! |
jreback
reviewed
Jan 21, 2017
| if _OS_FSPATH_INSTALLED and isinstance(filepath_or_buffer, PathLike): | ||
| return fspath(filepath_or_buffer) | ||
| elif hasattr(filepath_or_buffer, "__fspath__"): | ||
| return filepath_or_buffer.__fspath__() | ||
| if _PATHLIB_INSTALLED and isinstance(filepath_or_buffer, pathlib.Path): |
There was a problem hiding this comment.
might as well make the others elif
|
also need to add a |
|
@AnkurDedania ca you rebase / update |
CLN: from algos_rank_helper.pxi.in, algos_groupby_helper.pxi.in CLN: hashtable warns CLN: parser warnings closes pandas-dev#15190 Author: Jeff Reback <[email protected]> Closes pandas-dev#15259 from jreback/warn and squashes the following commits: 12cc061 [Jeff Reback] CLN: remove some warnings from algos_rank_helper.pxi.in CLN: and algos_groupby_helper.pxi.in CLN: hashtable warns CLN: parser warnings
When the numbers in `X` are large it can cause an overflow error on windows machine where the native `int` is 32 bit. Switching to np.intp alleviates this problem. Other fixes would include switching to np.uint32 or np.uint64. closes pandas-dev#15234 Author: David Hoffman <[email protected]> Closes pandas-dev#15265 from david-hoffman/patch-1 and squashes the following commits: c9c8d5e [David Hoffman] Update v0.19.2.txt d54583e [David Hoffman] Remove `test_large_input` because it's too big 47a6c6c [David Hoffman] Update test so that it will actually run on "normal" machine 7aeee85 [David Hoffman] Added tests for large numbers b196878 [David Hoffman] Fix overflow error in cartesian_product
closes pandas-dev#15289 Author: Michael Lamparski <[email protected]> Closes pandas-dev#15294 from ExpHP/bugfix-15289 and squashes the following commits: f349e0a [Michael Lamparski] BUG: Support empty dict-likes in replace()
xref pandas-dev#14854 Author: TrigonaMinima <[email protected]> Closes pandas-dev#15266 from TrigonaMinima/issue-14854-datetime and squashes the following commits: 6ee2bd9 [TrigonaMinima] TST: Splitting test_datetime.py into smaller chunks (gh14854) 415a748 [TrigonaMinima] TST: Moving DatetimeIndex related tests from test_timeseries.py and flake8 fixes c43c7de [TrigonaMinima] TST: proper naming of files 458d141 [TrigonaMinima] TST: splitting test_datetime.py 1ff0819 [TrigonaMinima] TST: fix flake8 errors - test_datetime.py (GH14854) 9311161 [TrigonaMinima] TST: reorg of DatetimeIndex tests from tseries/tests/test_base.py to test_datetime.py (GH14854) 54421a5 [TrigonaMinima] TST: reorg of DatetimeIndex tests from test_datetimelike.py to test_datetime.py (GH14854) f83814b [TrigonaMinima] TST: reorg of DatetimeIndex tests from test_timeseries.py to test_datetime.py
xref partial on pandas-dev#14854 Author: TrigonaMinima <[email protected]> Closes pandas-dev#15301 from TrigonaMinima/gh14854-timestamp and squashes the following commits: d8e3f4d [TrigonaMinima] splitting test_timeseries.py further 4072d93 [TrigonaMinima] TST: tseries/tests/test_timeseries.py tests moved to appropriate places. dbfd2ba [TrigonaMinima] TST: Timestamp tests compiled (gh14854)
TST: move parts of test_datetimelike.py to indexes/datetimes
… this more consistent with the Series API Author: Jeff Reback <[email protected]> Closes pandas-dev#15300 from jreback/null and squashes the following commits: 8c35656 [Jeff Reback] DOC: move Index.where to shared_docs e4502bf [Jeff Reback] ENH: .isnull and .notnull have been added as methods to Index to make this more consistent with the Series API
closes pandas-dev#15277 Author: Albert Villanova del Moral <[email protected]> Closes pandas-dev#15278 from albertvillanova/fix-15277 and squashes the following commits: 1b594a9 [Albert Villanova del Moral] Fix tab indentation 631a2dc [Albert Villanova del Moral] Add whatsnew note d691954 [Albert Villanova del Moral] BUG: Fix downcast argument for DataFrame.fillna()
xref pandas-dev#14904 Author: Jeff Reback <[email protected]> Closes pandas-dev#15322 from jreback/json and squashes the following commits: 0c2da60 [Jeff Reback] DOC: whatsnew update fa3deef [Jeff Reback] CLN: reorg pandas/io/json to sub-dirs
closes pandas-dev#15021 Author: Nicholas Ver Halen <[email protected]> Closes pandas-dev#15326 from verhalenn/issue15021 and squashes the following commits: 9fc3b4f [Nicholas Ver Halen] Updated the whatsnew for issue 15021 ec1f316 [Nicholas Ver Halen] Created a test for GH 15021 b8b10b0 [Nicholas Ver Halen] Added the on arg to resample on a grouped dataframe.
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-dev#10236, pandas-dev#10792, pandas-dev#10920. Author: gfyoung <[email protected]> Closes pandas-dev#15710 from gfyoung/create-last-kw-drop and squashes the following commits: b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
…parsers/parse_dates.py closes pandas-dev#15519 Author: Jaehoon Hwang <[email protected]> Closes pandas-dev#15707 from jaehoonhwang/TST15519 and squashes the following commits: 0b309d3 [Jaehoon Hwang] Fixed frame email and PEP8 ef6e8fa [Jaehoon Hwang] Fixing up few lines and imports e019e95 [Jaehoon Hwang] Imported read_table and using self.readcsv 3eb63c5 [Jaehoon Hwang] TST15519 Moving Unit tests to appropriate file 9b20caa [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master' b977615 [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master'
CI: use cache on all builds
This reverts commit 6a52c15.
Author: Jeff Reback <[email protected]> Closes pandas-dev#15734 from jreback/build and squashes the following commits: a99b713 [Jeff Reback] suppress the import json warning when generating _version ed7c526 [Jeff Reback] modify install tests 1cc5b67 [Jeff Reback] TST: have the build test exercise pandas.test()
Affect classes: 1) Index 2) Series 2) DataFrame xref pandas-devgh-10726
closes pandas-dev#14372 A Qt application cannot instantiate multiple `QApplication` instances, so we create a new `QApplication` only when the global `QApplication.instance()` is None. Author: Pankaj Pandey <[email protected]> Closes pandas-dev#14815 from pankajp/patch-2 and squashes the following commits: 40d70f9 [Pankaj Pandey] BUG: Fix linux clipboard QApplication() creation
closes pandas-dev#12747 Author: sinhrks <[email protected]> This patch had conflicts when merged, resolved by Committer: Jeff Reback <[email protected]> Closes pandas-dev#12780 from sinhrks/replace_type and squashes the following commits: f9154e8 [sinhrks] remove unnecessary comments 279fdf6 [sinhrks] remove import failure de44877 [sinhrks] BUG: replace coerces incorrect dtype
…dev#13303) closes pandas-dev#13303 Previously, calling a date/time attribute with Timestamp that's tz aware (e.g. `Timestamp('...', tz='...').dayofyear`) would return the attribute in UTC instead of the local tz. Author: Matt Roeschke <[email protected]> Closes pandas-dev#15740 from mroeschke/fix_13303 and squashes the following commits: b78b333 [Matt Roeschke] BUG: tz aware Timestamp field accessors returns local values (pandas-dev#13303)
The grep was initially matching to "pandas," which is incorrect because that was also matching files containing "pandas" in the name but that were not in the main `pandas` directory (e.g. performance test code). This change enforces that we match to any Python files in the main `pandas` directory. Also picked up compatibility issue with OSX, in which the `-r` flag does not exist. However, `xargs` terminates if the argument list is empty, which was the whole point of passing in `-r` in the first place. Follow-up to pandas-dev#15712 Author: gfyoung <[email protected]> Closes pandas-dev#15749 from gfyoung/flake8-diff-patch and squashes the following commits: d1543b5 [gfyoung] COMPAT: Do not run xargs with -r on OSX da57857 [gfyoung] DOC: Patch new flake8 command grep
Deprecated since 0.17.0. xref pandas-devgh-10892
closes pandas-dev#12963 Author: Matt Roeschke <[email protected]> Closes pandas-dev#15738 from mroeschke/fix_12963 and squashes the following commits: a020c10 [Matt Roeschke] PERF: Improve drop_duplicates for bool columns (pandas-dev#12963)
xref pandas-dev#15736 xref pandas-dev#12780 Author: Jeff Reback <[email protected]> Closes pandas-dev#15765 from jreback/common_types and squashes the following commits: d472646 [Jeff Reback] try removing restriction on windows 8d07cae [Jeff Reback] CLN: replace _interleave_dtype with _find_common_type
|
@AnkurDedania something went wrong. try then |
|
closing, you can cherry-pick your changes on top of master. ps open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff