TST: move pandas/tests/io/test_date_converters.py to pandas/tests/io/parsers/parse_dates.py #15707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving setUp from tests_dates_generator.py to function scope variable.
jaehoonhwang
changed the title
jreback
reviewed
Mar 17, 2017
| @@ -510,3 +512,148 @@ def test_parse_date_time_multi_level_column_name(self): | |||
| expected = DataFrame(expected_data, | |||
| columns=['date_time', ('A', 'a'), ('B', 'b')]) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_parse_date_time(self): | |||
| # From test_date_coverter | |||
|
pls remove the original file (test_date_converts.py)! ping on green. |
Import date, Multiindex and fixed self.readcsv added
jreback
requested changes
Mar 17, 2017
| from pandas import compat | ||
| from pandas.compat import parse_date, StringIO, lrange | ||
| from pandas.compat.numpy import np_array_datetime64_compat | ||
| from pandas.io.parsers import read_table |
There was a problem hiding this comment.
don't use read_table
instead these should use self.read_csv
| @@ -510,3 +513,148 @@ def test_parse_date_time_multi_level_column_name(self): | |||
| expected = DataFrame(expected_data, | |||
| columns=['date_time', ('A', 'a'), ('B', 'b')]) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_parse_date_time(self): | |||
There was a problem hiding this comment.
things that are strictly related the the actual parsing (e.g. just involve conv) can be put in a separate class; name it TestConverters (otherwise it won't be run)
There was a problem hiding this comment.
actually nvm about this comment
jreback
approved these changes
Mar 18, 2017
|
lgtm. ping on green. |
|
thanks! |
Codecov Report
@@ Coverage Diff @@
## master #15707 +/- ##
==========================================
- Coverage 91.03% 91% -0.03%
==========================================
Files 143 143
Lines 49411 49396 -15
==========================================
- Hits 44979 44951 -28
- Misses 4432 4445 +13
Continue to review full report at Codecov.
|
jaehoonhwang
changed the title
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
…parsers/parse_dates.py closes pandas-dev#15519 Author: Jaehoon Hwang <[email protected]> Closes pandas-dev#15707 from jaehoonhwang/TST15519 and squashes the following commits: 0b309d3 [Jaehoon Hwang] Fixed frame email and PEP8 ef6e8fa [Jaehoon Hwang] Fixing up few lines and imports e019e95 [Jaehoon Hwang] Imported read_table and using self.readcsv 3eb63c5 [Jaehoon Hwang] TST15519 Moving Unit tests to appropriate file 9b20caa [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master' b977615 [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master'
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
…parsers/parse_dates.py closes pandas-dev#15519 Author: Jaehoon Hwang <[email protected]> Closes pandas-dev#15707 from jaehoonhwang/TST15519 and squashes the following commits: 0b309d3 [Jaehoon Hwang] Fixed frame email and PEP8 ef6e8fa [Jaehoon Hwang] Fixing up few lines and imports e019e95 [Jaehoon Hwang] Imported read_table and using self.readcsv 3eb63c5 [Jaehoon Hwang] TST15519 Moving Unit tests to appropriate file 9b20caa [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master' b977615 [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffHow can I run tests on
parse_dates.py?I am getting
ValueError: no option named 'only_slow'withitem.config.getoption("--only-slow"):