Skip to content

COMPAT: xarray 0.9.0 #15282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Feb 1, 2017 · 1 comment · Fixed by #15285
Closed

COMPAT: xarray 0.9.0 #15282

jreback opened this issue Feb 1, 2017 · 1 comment · Fixed by #15285
Labels
Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Feb 1, 2017

https://github.com/pandas-dev/pandas/blob/master/pandas/tests/test_generic.py#L905

I believe should be changed to be version dependent, IOW, 0.9.0 pydata/xarray#700 fixes this.

we should fix one of the builds at say 0.8.2, and let the others float (they all float now)

@shoyer ?
@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Difficulty Novice Testing pandas testing functions or related to the test suite labels Feb 1, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 1, 2017
@shoyer
Copy link
Member

shoyer commented Feb 1, 2017

This was fixed a while ago, I think probably by pydata/xarray#875 (in xarray v0.8.0)

jreback added a commit to jreback/pandas that referenced this issue Feb 1, 2017
@jreback
COMPAT: xarray 0.8.2 test compat w.r.t. CategoricalIndex indempotency
ad4d073 
closes pandas-dev#15282
jreback added a commit to jreback/pandas that referenced this issue Feb 1, 2017
@jreback
COMPAT: xarray 0.8.2 test compat w.r.t. CategoricalIndex indempotency
ad44535 
closes pandas-dev#15282
@jreback jreback mentioned this issue Feb 1, 2017
Merged
jreback added a commit to jreback/pandas that referenced this issue Feb 1, 2017
@jreback
COMPAT: xarray 0.8.2 test compat w.r.t. CategoricalIndex indempotency
0ad7b94 
closes pandas-dev#15282
jreback added a commit that referenced this issue Feb 1, 2017
@jreback
COMPAT: xarray 0.8.2 test compat w.r.t. CategoricalIndex indempotency (…
8452080 
…#15285)

closes #15282
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@jreback @AnkurDedania
COMPAT: xarray 0.8.2 test compat w.r.t. CategoricalIndex indempotency (…
ab09d2d 
…pandas-dev#15285)

closes pandas-dev#15282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

COMPAT: xarray 0.8.2 test compat w.r.t. CategoricalIndex idempotency jreback/pandas
2 participants
@jreback @shoyer