Fix num_days in PandasAutoDateLocator #14716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a release note to |
|
is there an open issue for this? |
Current coverage is 85.21% (diff: 100%)@@ master #14716 diff @@
==========================================
Files 143 143
Lines 50796 50796
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43284 43284
Misses 7512 7512
Partials 0 0
|
|
can you add a whatsnew note (0.20.0) and is there a test / example that shows the current behavior (is incorrect)? |
|
can you rebase |
|
See discussion in #15753. Merging this as it was obviously a typo in the code, but one that will not affect any behaviour. |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, one year is worth 12 days, not 12 * 31 days.