Skip to content

TST: timeseries tests reorg #14854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 6 tasks
jreback opened this issue Dec 10, 2016 · 6 comments
Closed
1 of 6 tasks

TST: timeseries tests reorg #14854

jreback opened this issue Dec 10, 2016 · 6 comments
Labels
Testing pandas testing functions or related to the test suite
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Dec 10, 2016 •
edited
Loading

Datetime

we can separate these out to a single file in pandas/tests/indexes/test_datetime.py
The Base class (which powers lots of tests for the sub-classes DatetimeIndex, PeriodIndex, TimedeltaIndex), can move to pandas/tests/indexes/tests_datetimelike.py (and merge with the existing Datetimelike class).

  • create a pandas/tests/scalar/test_timestamp.py with Timestamp specific tests
    There are a lot of tests also in tseries/test_tslib.py, that can be merged into test_timestamp.py

  • the residuals (from tests_timeseries.py are Series tests speficially, these can move to pandas/tests/series/test_timeseries.py

Legacy Tests

Period

  • same idea with Period, the actual Period tests can be moved to tests/scalar/test_period.py, but move the index tests to tests/indexes/test_period.py (which can be stripped from here and here)

Timedelta

  • same idea with Timedelta, the actual Timedelta tests can be moved to tests/scalar/test_timedelta.py but move the index tests to tests/indexes/test_timedelta.py (which can be stripped from here and here)
@jreback jreback added Difficulty Novice Testing pandas testing functions or related to the test suite labels Dec 10, 2016
@jreback jreback added this to the Next Major Release milestone Dec 10, 2016
@TrigonaMinima
Copy link

@jreback Is anyone working on this?

@jreback
Copy link
Contributor Author

jreback commented Jan 29, 2017

nope - go for it

do this is discrete mergeable pieces

@TrigonaMinima
Copy link

@jreback I have started with pandas/tests/indexes/test_datetime.py first. I am not that familiar with the codebase. I might ask a few questions here and there, if that's okay with you. Like, this TestDateTimeIndexToJulianDate class looks like it should be sent to test_datetime.py. Is it okay to copy-paste the whole class and test it there?

@jreback
Copy link
Contributor Author

jreback commented Jan 29, 2017

yes

@TrigonaMinima
Copy link

Will these tests come under test_datetimeindex_accessors()?

@jreback
Copy link
Contributor Author

jreback commented Jan 29, 2017

@TrigonaMinima not sure what you mean.

Let me espouse the general idea here. Keep individual tests exactly the same (and classes as much as possible). We want to first simply move things around to group similar things together.

Next phases can dive deeper.

@TrigonaMinima TrigonaMinima mentioned this issue Jan 30, 2017
Closed
4 tasks
jreback pushed a commit that referenced this issue Feb 3, 2017
@jreback
TST: DatetimeIndex compiled together in test_datetime.py
da92a5c 
xref #14854

Author: TrigonaMinima <[email protected]>

Closes #15266 from TrigonaMinima/issue-14854-datetime and squashes the following commits:

6ee2bd9 [TrigonaMinima] TST: Splitting test_datetime.py into smaller chunks (gh14854)
415a748 [TrigonaMinima] TST: Moving DatetimeIndex related tests from test_timeseries.py and flake8 fixes
c43c7de [TrigonaMinima] TST: proper naming of files
458d141 [TrigonaMinima] TST: splitting test_datetime.py
1ff0819 [TrigonaMinima] TST: fix flake8 errors - test_datetime.py (GH14854)
9311161 [TrigonaMinima] TST: reorg of DatetimeIndex tests from tseries/tests/test_base.py to test_datetime.py (GH14854)
54421a5 [TrigonaMinima] TST: reorg of DatetimeIndex tests from test_datetimelike.py to test_datetime.py (GH14854)
f83814b [TrigonaMinima] TST: reorg of DatetimeIndex tests from test_timeseries.py to test_datetime.py
@TrigonaMinima TrigonaMinima mentioned this issue Feb 3, 2017
Closed
3 tasks
jreback pushed a commit to jreback/pandas that referenced this issue Feb 4, 2017
@jreback
TST: Timestamp and Timeseries tests reorg (gh14854)
69a9b05 
xref partial on pandas-dev#14854

Author: TrigonaMinima <[email protected]>

Closes pandas-dev#15301 from TrigonaMinima/gh14854-timestamp and squashes the following commits:

d8e3f4d [TrigonaMinima] splitting test_timeseries.py further
4072d93 [TrigonaMinima] TST: tseries/tests/test_timeseries.py tests moved to appropriate places.
dbfd2ba [TrigonaMinima] TST: Timestamp tests compiled (gh14854)
@TrigonaMinima TrigonaMinima mentioned this issue Feb 6, 2017
Closed
4 tasks
jreback pushed a commit that referenced this issue Feb 8, 2017
@jreback
TST/CLN: reorg more of tseries/tests
bf8194a 
xref #14854
closes #15324
@TrigonaMinima TrigonaMinima mentioned this issue Feb 8, 2017
Closed
4 tasks
jreback pushed a commit to jreback/pandas that referenced this issue Feb 9, 2017
@jreback
TST: Period tests reorg
9ba1008 
xref pandas-dev#14854
@TrigonaMinima TrigonaMinima mentioned this issue Feb 9, 2017
Closed
4 tasks
@jreback jreback modified the milestones: 0.20.0, Next Major Release Feb 9, 2017
@jreback jreback closed this as completed in f593ee8 Feb 9, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@AnkurDedania
TST: DatetimeIndex compiled together in test_datetime.py
951bbbb 
xref pandas-dev#14854

Author: TrigonaMinima <[email protected]>

Closes pandas-dev#15266 from TrigonaMinima/issue-14854-datetime and squashes the following commits:

6ee2bd9 [TrigonaMinima] TST: Splitting test_datetime.py into smaller chunks (gh14854)
415a748 [TrigonaMinima] TST: Moving DatetimeIndex related tests from test_timeseries.py and flake8 fixes
c43c7de [TrigonaMinima] TST: proper naming of files
458d141 [TrigonaMinima] TST: splitting test_datetime.py
1ff0819 [TrigonaMinima] TST: fix flake8 errors - test_datetime.py (GH14854)
9311161 [TrigonaMinima] TST: reorg of DatetimeIndex tests from tseries/tests/test_base.py to test_datetime.py (GH14854)
54421a5 [TrigonaMinima] TST: reorg of DatetimeIndex tests from test_datetimelike.py to test_datetime.py (GH14854)
f83814b [TrigonaMinima] TST: reorg of DatetimeIndex tests from test_timeseries.py to test_datetime.py
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@AnkurDedania
TST: Timestamp and Timeseries tests reorg (gh14854)
6ff9083 
xref partial on pandas-dev#14854

Author: TrigonaMinima <[email protected]>

Closes pandas-dev#15301 from TrigonaMinima/gh14854-timestamp and squashes the following commits:

d8e3f4d [TrigonaMinima] splitting test_timeseries.py further
4072d93 [TrigonaMinima] TST: tseries/tests/test_timeseries.py tests moved to appropriate places.
dbfd2ba [TrigonaMinima] TST: Timestamp tests compiled (gh14854)
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@AnkurDedania
TST/CLN: reorg more of tseries/tests
1fc92b9 
xref pandas-dev#14854
closes pandas-dev#15324
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@AnkurDedania
TST: Period tests reorg
97a0202 
xref pandas-dev#14854
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@AnkurDedania
TST: Remaining tseries tests reorg
89a4e92 
closes pandas-dev#14854
closes pandas-dev#15359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

TST: Remaining tseries tests reorg (gh14854)
2 participants
@jreback @TrigonaMinima