TST: Timedelta tests reorg (gh14854) #15324

TrigonaMinima · 2017-02-06T22:30:47Z

Partially completes TST: timeseries tests reorg #14854
Tests reorganized
passes git diff upstream/master | flake8 --diff
whatsnew: reorg of Timedelta tests

jreback · 2017-02-06T22:36:39Z

pandas/tests/indexes/timedeltas/test_to_timedelta.py

@@ -0,0 +1,201 @@
+from datetime import time, timedelta
+import numpy as np
+


-> test_tools.py

jreback · 2017-02-06T22:37:59Z

pandas/tseries/tests/test_period.py

@@ -6,27 +6,25 @@

 """

+import numpy as np
+from numpy.random import randn


you can move this to pandas/tests/scalar/test_period.py

This is a really big file (5k+ lines)

Still move it there?

sure can do in anthoher PR. I though you moved the PeriodIndex tests out already. But yes, certainly should split it.

jreback · 2017-02-06T22:38:54Z

@TrigonaMinima looks great!

just a couple of corrections.

jreback · 2017-02-06T22:40:03Z

pls add a whatsnew note as well (reorg of timeseries tests), you can put in other API changes section (in 0.20.0)

jreback · 2017-02-06T22:40:48Z

only thing left after this are the timeseries_legacy.py tests I think (but let's deal with them in a separate PR).

TrigonaMinima · 2017-02-06T22:42:20Z

I haven't finished the reorg of Period tests yet. Should I do it in this PR only?

jreback · 2017-02-06T22:47:03Z

@TrigonaMinima no, let's leave period for another.

jreback · 2017-02-06T22:47:22Z

pandas/tests/indexes/period/test_period.py

+from datetime import timedelta
+
+import pandas as pd
+from pandas.util import testing as tm


so you moved this (just fine).

jreback · 2017-02-06T22:48:03Z

pandas/tests/indexes/test_datetimelike.py

@@ -1,467 +0,0 @@
-# -*- coding: utf-8 -*-
-
-import numpy as np


and removed all of this (again just fine). that's why I thought you were moving Period. But can certainly finish in another.

TrigonaMinima · 2017-02-06T22:57:29Z

@jreback I tried by best, but there were still some confusions. So, could you please have somewhat deeper look at it. I'll correct the issues if there are any, tomorrow night.

jreback · 2017-02-06T23:23:25Z

what confusions?

TrigonaMinima · 2017-02-06T23:39:56Z

Some coercion functions from tseries/test_tslib.py I moved to indexing/test_coercion.py.
_conversion and _format_converters functions (currently in scalar/test_timedelta.py) to be sent to scalar/test_timedelta or indexes/timedeltas?
test_timedelta_ops_scalar (currently in indexes/timedeltas/test_ops.py) in scalar/test_timedelta.py or indexes/timedeltas? Here I was confused because there were some arithmetic operations going on between Timedelta and Timestamp but it said scalar.
This function - test_add_overflow was under class TestSlicing (currently in tests/test_ops.py). Why was that? I almost placed it in test_partial_slicing.py.

TrigonaMinima · 2017-02-06T23:43:21Z

Also, I want to understand the code of the core pandas library. Any suggestions on what should the starting point be?

jreback · 2017-02-06T23:45:25Z

ok i will have a look and see if anything needs moving

so best way to understand code is to:

debug or write a test, then step thru and see what it does

starting with a Series or DataFrame method is useful to see

jreback · 2017-02-07T15:37:39Z

@TrigonaMinima some flake errors.

I'll have a look at your points above when merging.

…range.py

codecov-io · 2017-02-07T18:33:32Z

Codecov Report

Merging #15324 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master   #15324      +/-   ##
==========================================
+ Coverage   86.32%   86.33%   +<.01%     
==========================================
  Files         141      141              
  Lines       51164    51164              
==========================================
+ Hits        44169    44170       +1     
+ Misses       6995     6994       -1

Impacted Files	Coverage Δ
pandas/core/common.py	`91.36% <ø> (+0.33%)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d57450...b24b95d. Read the comment docs.

jreback · 2017-02-07T19:27:22Z

pandas/tests/indexing/test_coercion.py

@@ -1260,3 +1263,61 @@ def test_replace_series_timedelta64(self):

    def test_replace_series_period(self):
        pass
+
+
+class TestArrayToDatetime(tm.TestCase):


these go in: pandas/tests/datetimes/tests/test_tools.py

TrigonaMinima · 2017-02-07T19:58:43Z

@jreback don't know what to do with this build/merge error.

I have fixed the merge conflicts. I am able to merge this branch to master without any conflicts on my local repo.

jreback · 2017-02-07T20:56:35Z

ok np i'll fix this up

jreback · 2017-02-07T23:55:57Z

https://github.com/pandas-dev/pandas/compare/master...jreback:TrigonaMinima-gh14854-timedelta?expand=1

is the compare, with a couple of changes from on top.

@TrigonaMinima really appreciate the PRs here! segregated tests that are not in huge files are awesome!

jreback · 2017-02-08T00:45:07Z

@TrigonaMinima thanks again for this!

love for you to keep going (period tests!)

keep in mind we are switching to pytest very shortly (its should work similarly though).

xref pandas-dev#14854 closes pandas-dev#15324

jreback added Clean Testing pandas testing functions or related to the test suite labels Feb 6, 2017

jreback reviewed Feb 6, 2017

View reviewed changes

jreback added this to the 0.20.0 milestone Feb 6, 2017

jreback reviewed Feb 6, 2017

View reviewed changes

TrigonaMinima added 5 commits February 7, 2017 23:37

tseries/tests/test_daterange.py to tests/indexes/datetimes/test_date_…

7c2fd37

…range.py

reorg of timedelta tests

fe57e4d

test_to_timedelta.py renamed to test_tools.py

8236cc8

Duplicate function removal

d68d639

fixing flake8 errors

08dad9a

jreback reviewed Feb 7, 2017

View reviewed changes

Other reorg issues

b24b95d

jreback mentioned this pull request Feb 8, 2017

TST: Use pytest #13856

Closed

4 tasks

jreback closed this in bf8194a Feb 8, 2017

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017

TST/CLN: reorg more of tseries/tests

1fc92b9

xref pandas-dev#14854 closes pandas-dev#15324

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Timedelta tests reorg (gh14854) #15324

TST: Timedelta tests reorg (gh14854) #15324

TrigonaMinima commented Feb 6, 2017 •

edited

Loading

jreback Feb 6, 2017

jreback Feb 6, 2017

TrigonaMinima Feb 6, 2017

jreback Feb 6, 2017

jreback commented Feb 6, 2017

jreback commented Feb 6, 2017

jreback commented Feb 6, 2017

TrigonaMinima commented Feb 6, 2017

jreback commented Feb 6, 2017

jreback Feb 6, 2017

jreback Feb 6, 2017

TrigonaMinima commented Feb 6, 2017

jreback commented Feb 6, 2017

TrigonaMinima commented Feb 6, 2017

TrigonaMinima commented Feb 6, 2017

jreback commented Feb 6, 2017

jreback commented Feb 7, 2017

codecov-io commented Feb 7, 2017 •

edited

Loading

jreback Feb 7, 2017

TrigonaMinima commented Feb 7, 2017

jreback commented Feb 7, 2017

jreback commented Feb 7, 2017

jreback commented Feb 8, 2017

		@@ -0,0 +1,201 @@
		from datetime import time, timedelta
		import numpy as np

TST: Timedelta tests reorg (gh14854) #15324

TST: Timedelta tests reorg (gh14854) #15324

Conversation

TrigonaMinima commented Feb 6, 2017 • edited Loading

jreback Feb 6, 2017

Choose a reason for hiding this comment

jreback Feb 6, 2017

Choose a reason for hiding this comment

TrigonaMinima Feb 6, 2017

Choose a reason for hiding this comment

jreback Feb 6, 2017

Choose a reason for hiding this comment

jreback commented Feb 6, 2017

jreback commented Feb 6, 2017

jreback commented Feb 6, 2017

TrigonaMinima commented Feb 6, 2017

jreback commented Feb 6, 2017

jreback Feb 6, 2017

Choose a reason for hiding this comment

jreback Feb 6, 2017

Choose a reason for hiding this comment

TrigonaMinima commented Feb 6, 2017

jreback commented Feb 6, 2017

TrigonaMinima commented Feb 6, 2017

TrigonaMinima commented Feb 6, 2017

jreback commented Feb 6, 2017

jreback commented Feb 7, 2017

codecov-io commented Feb 7, 2017 • edited Loading

Codecov Report

jreback Feb 7, 2017

Choose a reason for hiding this comment

TrigonaMinima commented Feb 7, 2017

jreback commented Feb 7, 2017

jreback commented Feb 7, 2017

jreback commented Feb 8, 2017

TrigonaMinima commented Feb 6, 2017 •

edited

Loading

codecov-io commented Feb 7, 2017 •

edited

Loading