TST: Period tests reorg (gh14854)

[TrigonaMinima]

• Almost completes TST: timeseries tests reorg #14854
• tests reorg
• passes git diff upstream/master | flake8 --diff
• whatsnew: Reorganization of Period tests.

[jreback]

whoosh that test_period was huge. ok. ping when green.

[TrigonaMinima]

hahah yeah. As a result, scalar/test_period.py and indexes/period/test_ops.py have gotten big as well.

[jreback]

yep
certainly can come back later and split things a bit

but let's wait on that for now

[jreback]

@TrigonaMinima going to merge shortly.

[codecov-io]

Codecov Report

Merging #15352 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master   #15352      +/-   ##
==========================================
+ Coverage   86.32%   86.32%   +<.01%     
==========================================
  Files         141      141              
  Lines       51163    51163              
==========================================
+ Hits        44166    44167       +1     
+ Misses       6997     6996       -1

Impacted Files	Coverage Δ
pandas/tseries/index.py	95.42% <ø> (+0.09%)	✅

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704cdbf...b28eec7. Read the comment docs.

[jreback]

thanks again @TrigonaMinima !

if you are up for more :>

let's move the remainder of tseries/tests to pandas/tests/tseries

also let's remove tests/timeseries_legacy.py (and some of data can be removed as well).

BUT should move any useful tests to a proper location. IOW the pickle things you can simply remove (they are really old). but some of the freq tests might be useful.

[TrigonaMinima]

Sure. I'll try to do it tonight.

I should also thank you. You are helping me alot throughout the way.

Is there something remaining to be done in this PR?

[jreback]

closed via 9ba1008

@TrigonaMinima no this is all good. thanks!