TST: Timestamp and Timeseries tests reorg (gh14854) #15301

TrigonaMinima · 2017-02-03T20:46:57Z

Partially completes TST: timeseries tests reorg #14854
Tests reorganized (test_timeseries.py + test_tslib.py -> test_timestamp.py)
Passes git diff upstream/master | flake8 --diff

jreback · 2017-02-03T21:10:52Z

lgtm. the remainder of tseries/test_timeseries.py can prob go in tests/series/test_timestamp.py (or can move the obvious stuff). Then can look and see what remains.

thanks!

TrigonaMinima · 2017-02-03T21:27:27Z

Wouldn't the remaining tests of tseries/test_timeseries.py go in tests/series/test_timeseries.py instead of tests/series/test_timestamp.py? You have also mentioned the same in the issue ( #14854 3rd point).

jreback · 2017-02-03T21:35:46Z

@TrigonaMinima yes, sorry, that's what I meant!

of course if you find say a period test or something, move to the appropriate place.

codecov-io · 2017-02-04T06:25:19Z

Codecov Report

Merging #15301 into master will not impact coverage.

@@           Coverage Diff           @@
##           master   #15301   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files         139      139           
  Lines       51149    51149           
=======================================
  Hits        44157    44157           
  Misses       6992     6992

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddba8d...285387f. Read the comment docs.

jreback · 2017-02-04T14:01:00Z

ok a lot of the move into tests/series/test_timestamp.py was composed of things (that can be split out)

fillna (on series) can go to test_missing
move pure date_range tests an go to indexes/datetimes/test_date_range (new file)
maybe some pure Timestamp things to scalar/test_timestamp

TrigonaMinima · 2017-02-04T15:42:08Z

You meant tests/series/test_timeseries.py, right? 😄

It's still large though.

jreback · 2017-02-04T15:46:42Z

@TrigonaMinima yeah. Need to separate pieces out as much as possible (though still may end up large). ok for now. I'll take a look and move more.

jreback · 2017-02-04T15:49:52Z

pandas/tests/series/test_missing.py

+        expected = expected.to_sparse()
+        assert_series_equal(result, expected)
+
+    def test_sparse_series_pad_backfill_limit(self):


forgot to mention, these sparse routines can go in

pandas/sparse/tests/test_series.py

jreback · 2017-02-04T15:50:14Z

pandas/tests/series/test_missing.py

+        expected = expected.to_sparse()
+        assert_series_equal(result, expected)
+
+    def test_series_pad_backfill_limit(self):


anything backfill or interpolate can also do in pandas/tests/series/test_missing

sorry, I realized you already moved this, nvm!

They are in test_missing only. Though there are some frame backfill routines which are in test_timeseries.py. Should they be moved here as well?

jreback · 2017-02-04T15:50:28Z

pandas/tests/series/test_missing.py

+        expected = s[-2:].reindex(index).fillna(method='backfill')
+        expected[:3] = np.nan
+        assert_series_equal(result, expected)
+

 class TestSeriesInterpolateData(TestData, tm.TestCase):


in fact this whole class can be moved

already in test_missing 🙂

jreback · 2017-02-04T15:52:57Z

@TrigonaMinima just ping on green. I'll do a follow on this stuff to fix a couple of little points.

If you can continue on to other things would be great!

jreback · 2017-02-04T17:55:44Z

@TrigonaMinima don't push anymore to this. I have already taken your commit (and going to merge it soon), along with a bunch of other changes.

TrigonaMinima · 2017-02-04T17:56:49Z

Sure. When I pushed it there wasn't anything. Sorry for that.

jreback · 2017-02-04T18:04:26Z

@TrigonaMinima no prob.

https://github.com/pandas-dev/pandas/compare/master...jreback:fix-tests?expand=1

is the diff

jreback · 2017-02-04T18:08:16Z

@TrigonaMinima if you are game, love to move timedelta and period in a similar way (e.g. move the scalar tests and index tests). you can create a indexes/timedeltas,period sub-dir

e.g. for timedelta separate out the to_timedelta stuff into a separate file apart from multiple files for timedelta index consruction / ops etc.

similar for period.

jreback · 2017-02-04T18:10:26Z

also you can move tserites/tests/test_daterange.py to indexes/datetimes/test_date_range (add to same file).

jreback · 2017-02-04T18:14:58Z

and tseries/tests/test_tslib.py can go to (you will have to move classes / individual test)
can also hit tseires/tests_util.py at same time I think.

test_timezones.py (only move stuff that is actually doing timezone stuff, not parsing timezones, that will be in below)
indexes/datetimes/test_tools.py (for parsing and tslib.* routines)
test_period.py
a couple of random things at the bottom have to find a good spot.

do this after I merge (shortly) and separately from everything else as this will touch lots of things.

TrigonaMinima · 2017-02-04T18:16:28Z

@jreback sure. I just have a couple of questions-

Why are there tests outside tests directory? What's the difference between these tests in pandas/tests and in each sub directory under pandas? Is it by design?
What goes under scalars and what goes under indexes. Some routines seemed to me as if they could go anywhere. So if there is some part of documentation where i can know the difference or may be you can explain it to me.

Also, just clarifying, I should do timedelta changes in a different PR right?

jreback · 2017-02-04T18:20:45Z

yes, leave this PR alone. timedelta is a separate PR.

in theory everything should be under pandas/tests (sub-dirs of). but we have historically not done that, so slowly moving things.

so in the scalar dir are Timestamp, Timedelta, Period specific things, as opposed to DatetimeIndex, TimedeltaIndex, PeriodIndex (which are the indexes which wrap these scalars).

e.g. a method/property of Timestamp belongs in scalar, while using Timestamp to say subtract from a DatetimeIndex belong in indexes.

the tests dir should be almost self-explanatory, with it obvious where a new tests should go. there should be 1 and only 1 place.

jreback · 2017-02-04T18:28:31Z

merged!

TrigonaMinima · 2017-02-04T18:30:05Z

Thanks. The explanation made things clearer.

xref partial on pandas-dev#14854 Author: TrigonaMinima <[email protected]> Closes pandas-dev#15301 from TrigonaMinima/gh14854-timestamp and squashes the following commits: d8e3f4d [TrigonaMinima] splitting test_timeseries.py further 4072d93 [TrigonaMinima] TST: tseries/tests/test_timeseries.py tests moved to appropriate places. dbfd2ba [TrigonaMinima] TST: Timestamp tests compiled (gh14854)

TST: Timestamp tests compiled (gh14854)

dbfd2ba

jreback added the Testing pandas testing functions or related to the test suite label Feb 3, 2017

jreback added this to the 0.20.0 milestone Feb 3, 2017

TST: tseries/tests/test_timeseries.py tests moved to appropriate places.

4072d93

TrigonaMinima changed the title ~~TST: Timestamp tests compiled (gh14854)~~ TST: Timestamp and Timeseries tests reorg (gh14854) Feb 4, 2017

splitting test_timeseries.py further

d8e3f4d

jreback reviewed Feb 4, 2017

View reviewed changes

further reorg of sparse routines

285387f

jreback closed this in 69a9b05 Feb 4, 2017

TrigonaMinima deleted the gh14854-timestamp branch February 4, 2017 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Timestamp and Timeseries tests reorg (gh14854) #15301

TST: Timestamp and Timeseries tests reorg (gh14854) #15301

TrigonaMinima commented Feb 3, 2017 •

edited

Loading

jreback commented Feb 3, 2017

TrigonaMinima commented Feb 3, 2017

jreback commented Feb 3, 2017

codecov-io commented Feb 4, 2017 •

edited

Loading

jreback commented Feb 4, 2017

TrigonaMinima commented Feb 4, 2017 •

edited

Loading

jreback commented Feb 4, 2017

jreback Feb 4, 2017

jreback Feb 4, 2017

jreback Feb 4, 2017

TrigonaMinima Feb 4, 2017

jreback Feb 4, 2017

TrigonaMinima Feb 4, 2017

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

TrigonaMinima commented Feb 4, 2017

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017 •

edited

Loading

TrigonaMinima commented Feb 4, 2017 •

edited

Loading

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

TrigonaMinima commented Feb 4, 2017

TST: Timestamp and Timeseries tests reorg (gh14854) #15301

TST: Timestamp and Timeseries tests reorg (gh14854) #15301

Conversation

TrigonaMinima commented Feb 3, 2017 • edited Loading

jreback commented Feb 3, 2017

TrigonaMinima commented Feb 3, 2017

jreback commented Feb 3, 2017

codecov-io commented Feb 4, 2017 • edited Loading

Codecov Report

jreback commented Feb 4, 2017

TrigonaMinima commented Feb 4, 2017 • edited Loading

jreback commented Feb 4, 2017

jreback Feb 4, 2017

Choose a reason for hiding this comment

jreback Feb 4, 2017

Choose a reason for hiding this comment

jreback Feb 4, 2017

Choose a reason for hiding this comment

TrigonaMinima Feb 4, 2017

Choose a reason for hiding this comment

jreback Feb 4, 2017

Choose a reason for hiding this comment

TrigonaMinima Feb 4, 2017

Choose a reason for hiding this comment

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

TrigonaMinima commented Feb 4, 2017

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017 • edited Loading

TrigonaMinima commented Feb 4, 2017 • edited Loading

jreback commented Feb 4, 2017

jreback commented Feb 4, 2017

TrigonaMinima commented Feb 4, 2017

TrigonaMinima commented Feb 3, 2017 •

edited

Loading

codecov-io commented Feb 4, 2017 •

edited

Loading

TrigonaMinima commented Feb 4, 2017 •

edited

Loading

jreback commented Feb 4, 2017 •

edited

Loading

TrigonaMinima commented Feb 4, 2017 •

edited

Loading