BUG: Fix downcast argument for DataFrame.fillna() #15278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
albertvillanova
commented
Feb 1, 2017
•
albertvillanova
commented
- closes DataFrame.fillna() downcast argument does not work when the value for fillna is a dict instead of a scalar #15277
- tests added / passed
- passes git diff upstream/master | flake8 --diff
- whatsnew entry
albertvillanova
changed the title
|
needs tests, pls add for both series & dataframe (in pandas/tests/series/test_missing.py and similar for frame). add alongside the existing tests pls add a whatsnew note (bug fixes for 0.20.0) |
jreback
added
Bug
Missing-data
Codecov Report
@@ Coverage Diff @@
## master #15278 +/- ##
==========================================
- Coverage 86.33% 86.32% -0.01%
==========================================
Files 139 139
Lines 51149 51157 +8
==========================================
+ Hits 44157 44162 +5
- Misses 6992 6995 +3
Continue to review full report at Codecov.
|
closes pandas-dev#15277 Author: Albert Villanova del Moral <[email protected]>
albertvillanova
force-pushed
the
fix-15277
branch
from
112c8a6 to
d691954
Compare
jreback
reviewed
Feb 3, 2017
pandas/tests/series/test_missing.py
Outdated
| @@ -268,6 +268,19 @@ def test_datetime64tz_fillna_round_issue(self): | |||
|
|
|||
| assert_series_equal(filled, expected) | |||
|
|
|||
| def test_fillna_downcast(self): | |||
| # infer int64 from float64 | |||
| s = pd.Series([1., np.nan]) | |||
|
lgtm. though you are going to fail linting because of indentation :< ping on green |
|
Is it OK now or some additional changes are needed? Should I squash all the commits into a single one? |
|
thanks @albertvillanova squashing is really no longer necessary as our merging process will squash (and retain the commit links). |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
closes pandas-dev#15277 Author: Albert Villanova del Moral <[email protected]> Closes pandas-dev#15278 from albertvillanova/fix-15277 and squashes the following commits: 1b594a9 [Albert Villanova del Moral] Fix tab indentation 631a2dc [Albert Villanova del Moral] Add whatsnew note d691954 [Albert Villanova del Moral] BUG: Fix downcast argument for DataFrame.fillna()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.