BUG: Support empty dict-likes in replace() #15294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Feb 2, 2017
pandas/tests/frame/test_replace.py
Outdated
| @@ -1055,3 +1055,12 @@ def test_replace_datetimetz(self): | |||
| Timestamp('20130103', tz='US/Eastern')], | |||
| 'B': [0, np.nan, 2]}) | |||
| assert_frame_equal(result, expected) | |||
|
|
|||
| def test_replace_with_empty_dictlike(self): | |||
| mix = {'a': lrange(4), 'b': list('ab..'), 'c': ['a', 'b', nan, 'd']} | |||
There was a problem hiding this comment.
add the issue number in a comment
pandas/tests/series/test_replace.py
Outdated
| @@ -223,3 +223,8 @@ def test_replace2(self): | |||
| self.assertTrue((ser[:5] == -1).all()) | |||
| self.assertTrue((ser[6:10] == -1).all()) | |||
| self.assertTrue((ser[20:30] == -1).all()) | |||
|
|
|||
| def test_replace_with_empty_dictlike(self): | |||
| s = pd.Series(list('abcd')) | |||
Codecov Report@@ Coverage Diff @@
## master #15294 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 139 139
Lines 51149 51149
=======================================
Hits 44157 44157
Misses 6992 6992
Continue to review full report at Codecov.
|
|
thanks @ExpHP nice PR! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
closes pandas-dev#15289 Author: Michael Lamparski <[email protected]> Closes pandas-dev#15294 from ExpHP/bugfix-15289 and squashes the following commits: f349e0a [Michael Lamparski] BUG: Support empty dict-likes in replace()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff