BUG: Fix linux clipboard QApplication() creation #14815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pandas-dev#14372 A Qt application cannot instantiate multiple `QApplication` instances, so we create a new `QApplication` only when the global `QApplication.instance()` is None. Failing sample: ``` from PyQt4.QtGui import QApplication myapp = QApplication([]) from pandas.util.clipboard import clipboard_get # <--- ERROR File "prefix/lib/python2.7/site-packages/pandas/util/clipboard.py", line 164, in <module> app = qt4.QtGui.QApplication([]) RuntimeError: A QApplication instance already exists. ```
jorisvandenbossche
added
the
IO Data
|
this should be addressed upstream pls file a report with pyoerclip |
Current coverage is 85.27% (diff: 0.00%)@@ master #14815 diff @@
==========================================
Files 144 144
Lines 50968 50968
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43466 43465 -1
- Misses 7502 7503 +1
Partials 0 0
|
|
can you add a whatsnew note (0.20.0) |
jreback
requested changes
Jan 21, 2017
| @@ -50,7 +50,7 @@ def init_qt_clipboard(): | |||
| # $DISPLAY should exist | |||
| from PyQt4.QtGui import QApplication | |||
|
|
|||
| app = QApplication([]) | |||
There was a problem hiding this comment.
can you add a comment here
|
thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
closes pandas-dev#14372 A Qt application cannot instantiate multiple `QApplication` instances, so we create a new `QApplication` only when the global `QApplication.instance()` is None. Author: Pankaj Pandey <[email protected]> Closes pandas-dev#14815 from pankajp/patch-2 and squashes the following commits: 40d70f9 [Pankaj Pandey] BUG: Fix linux clipboard QApplication() creation
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
closes pandas-dev#14372 A Qt application cannot instantiate multiple `QApplication` instances, so we create a new `QApplication` only when the global `QApplication.instance()` is None. Author: Pankaj Pandey <[email protected]> Closes pandas-dev#14815 from pankajp/patch-2 and squashes the following commits: 40d70f9 [Pankaj Pandey] BUG: Fix linux clipboard QApplication() creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Qt application cannot instantiate multiple
QApplicationinstances,so we create a new
QApplicationonly when the globalQApplication.instance()is None.Failing sample (gtk should not be installed for pandas to use qt clipboard):