BUG: Fix linux Qt clipboard QApplication() creation #14371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Qt application cannot instantiate multiple `QApplication` instances, so we create a new `QApplication` only when the global `QApplication.instance()` is None.
Current coverage is 85.26% (diff: 100%)@@ master #14371 diff @@
==========================================
Files 140 140
Lines 50632 50632
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43171 43170 -1
- Misses 7461 7462 +1
Partials 0 0
|
|
I don't think any of our clipboard tests actually work on travis, xref #9693 ideally we can resolve this first. |
|
our pyperclip has been added quite subtantially in master, so pls re-tests and re-open if needed. |
|
Reopened on changed file as #14815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14372
A Qt application cannot instantiate multiple
QApplicationinstances,so we create a new
QApplicationonly when the globalQApplication.instance()is None.Failing sample: