Update vendored pyperclip to 1.5.8

[jcjf]

Resolves #9263

Tested:

• windows
• macosx
• linux

[jreback]

add this to the first line of test_clipboard.py

# -*- coding: utf-8 -*-

[jcjf]

Yeah, I took a look at Travis too... I forgot about those Python 2 peoples!

[jreback]

@jcjf further, what platform are you testing this on? (as this requires some 'manual' testing I think), pls check the appropriate box

[jcjf]

Hmm... this might be related to asweigart/pyperclip#11

One alternative is to only update the win32 parts of pyperclip. We could take that from pyperclip itself or perhaps from https://github.com/pyreadline/pyreadline/blob/master/pyreadline/clipboard/win32_clipboard.py

[jcjf]

@jreback Suggested path forward?

[jreback]

actually I think what u did is ok

the test is failing because xclip / xsel is not installed

iirc we were doing this in the install script somewhere

have a look in ci/install_conda.py

lmk

[jreback]

@jcjf can u update?

[jcjf]

I've been very busy recently and haven't had time to take another look at
this.

On 10 May 2015 at 04:16, jreback [email protected] wrote:

@jcjf https://github.com/jcjf can u update?

—
Reply to this email directly or view it on GitHub
#9693 (comment).

[jcjf]

So basically my earlier attempts forgot to maintain compatibility by raising a subclass of OSError.

I believe the CI builds don't actually test the GTK+ 2 clipboard properly. There isn't any setup that would make import gtk work on its own. However, I claim that this was broken before remains broken now, and most people will be using xclip / xsel / PyQt4 / PySide anyway.

[jreback]

ok, looks reasonable, can you add a release note for 0.17.0 with the referenced issue. We are claiming this is just a bug fix, yes? (e.g. it now supports unicode on windows).

squash.

Then need to have people tests this out on various system, e.g. some manual validation.

[jreback]

can you rebase?

[jreback]

this looks reasonable. can people give this a whirl to make sure it works?

[jreback]

ok, this works on windows, but is failing on mac. any ideas? (I think working on linux as travis is passing)

[jreback]

@jcjf want to rebase this

[jcjf]

pyperclip upstream has updated to 1.5.15 - maintain the change 1.5.11 only or try to update?

[jreback]

@jcjf that sounds fine. The main issue I think was testing on this.

[jreback]

can you rebase this

[jreback]

ok, can you rebase & add a whatsnew note for 0.18.0

[jcjf]

@jreback I've rebased this for the third time now. Can you please indicate whether this is still failing on mac and whether you intend to merge this soon?

[jreback]

This doesn't pass on macosx, not really sure why. Does this pass on windows?

======================================================================
FAIL: test_round_trip_frame_sep (pandas.io.tests.test_clipboard.TestClipboard)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jreback/pandas/pandas/io/tests/test_clipboard.py", line 71, in test_round_trip_frame_sep
    self.check_round_trip_frame(dt,sep=',')
  File "/Users/jreback/pandas/pandas/io/tests/test_clipboard.py", line 67, in check_round_trip_frame
    tm.assert_frame_equal(data, result, check_dtype=False)
  File "/Users/jreback/pandas/pandas/util/testing.py", line 1012, in assert_frame_equal
    '{0}, {1}'.format(right.shape[1], right.columns))
  File "/Users/jreback/pandas/pandas/util/testing.py", line 819, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: DataFrame are different

DataFrame shape (number of columns) are different
[left]:  2, Index([u'en', u'es'], dtype='object')
[right]: 0, Index([], dtype='object')

seems the index is not matching on the nonascii

(Pdb) p data
        en       es
0       in       en
1  English  espa?ol
(Pdb) p result
Empty DataFrame
Columns: []
Index: [0       in       en, 1  English  espa?ol]
(Pdb) p read_clipboard(sep=sep)
           en       es
0  0       in       en
1  1  English  espa?ol
(Pdb) p read_clipboard(sep=sep,index_col=0)
Empty DataFrame
Columns: []
Index: [0       in       en, 1  English  espa?ol]

[jreback]

these seem to all pass on windows.

[jreback]

I will amend. These seem to pass on a vanlilla terminal in macosx, I have a weird xterm going.

[jreback]

merged via 925f62a

thanks!