DOC: Added docs to clarify that MultiIndex.set_levels() interprets passed values as new components of the .levels attribute (#28294) #28797
Conversation
hweecat
force-pushed
the
docfix-multiindex-setlevels
branch
2 times, most recently
from
623cc3a to
6faac69
Compare
shortened lines to pass checks
hweecat
force-pushed
the
docfix-multiindex-setlevels
branch
from
6faac69 to
e8256cc
Compare
hweecat
changed the title
doc/source/user_guide/advanced.rst
Outdated
| @@ -177,6 +177,37 @@ completely analogous way to selecting a column in a regular DataFrame: | |||
| See :ref:`Cross-section with hierarchical index <advanced.xs>` for how to select | |||
| on a deeper level. | |||
|
|
|||
| .. _advanced.set_levels: | |||
There was a problem hiding this comment.
I would rather just edit the actual set_levels doc-string with examples. This is too much for the main docs (and not generally what someone would want).
There was a problem hiding this comment.
Good point. I've edited the docstring for set_levels instead - let me know if you have any ideas on how we could improve the explanation.
edit set_levels docstring with additional examples edit set_levels docstring with additional examples
hweecat
force-pushed
the
docfix-multiindex-setlevels
branch
from
261264c to
d9130f2
Compare
Corrects the spelling of compiler
…utes type updated to str instead of string (pandas-dev#28887)
resolve pep8 issues explain set_levels().levels examples + formatting
…etlevels' of https://github.com/hweecat/pandas into docfix-multiindex-setlevels explain set_levels().levels + formatting
resolve trailing whitespaces
|
Travis CI is failing at Python 3.8-dev but passes for Python 3.6 and 3.7 - not too sure how to resolve this. https://travis-ci.org/pandas-dev/pandas/jobs/600207880 Edit: Synced my fork with upstream fork in order to pass Travis CI for Python 3.8. |
shortened lines to pass checks
edit set_levels docstring with additional examples edit set_levels docstring with additional examples
resolve trailing whitespaces
…cat/pandas into docfix-multiindex-setlevels
|
@hweecat I'm not sure what happened but the git diff on this seems to have pulled in close to 200 files Are you still fixing that up? It might be easier to start fresh with a new branch if unsure what happened |
|
@WillAyd I think it could be because I tried to sync my fork with the upstream in order to pass Travis CI for Python 3.8 (Travis CI kept failing for Python 3.8 previously: https://travis-ci.org/pandas-dev/pandas/jobs/600207880). Think I might need to start fresh with a new branch (from the master that is synced with the latest upstream) and add changes to that branch. Does that mean I might have to create a new pull request? If yes, I'll proceed to start fresh with a new pull request. |
|
Yea it might be easiest to just do that at this point |
|
Superseded by #29143 |
Added documentation on MultiIndex.set_levels to clarify that MultiIndex.set_levels() interprets passed values as new components of the .levels attribute
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffHere's my first PR to pandas - looking forward to feedback on how I can further improve this.