TST: regression test for groupby with datetime and timedelta (#15562) #29063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 17, 2019
pandas/tests/groupby/test_apply.py
Outdated
| B,2017-02-01 00:00:00 | ||
| C,2017-02-01 00:00:00""" | ||
|
|
||
| df = pd.read_csv(StringIO(s)) |
There was a problem hiding this comment.
Can you construct the dataframe manually without reading it as a csv?
df = pd.DataFrame([...])
mroeschke
reviewed
Oct 17, 2019
pandas/tests/groupby/test_apply.py
Outdated
| dict(clientid_age=ddf.time_delta_zero.min(), date=ddf.datetime.min()) | ||
| ) | ||
| ) | ||
| assert result.shape == (3, 2) |
There was a problem hiding this comment.
Can you construct the expected dataframe and use tm.assert_frame_equal?
There was a problem hiding this comment.
yes. just pushed the update.
jhereth
force-pushed
the
15562_regression_test
branch
from
f21c172 to
4c580c3
Compare
|
@mroeschke Change has been pushed. Some azure pipeline timed out. Is there a way to restart tests? Or should I re-push my branch? (update: Apparently the command/comment |
|
Commenter does not have sufficient privileges for PR 29063 in repo pandas-dev/pandas |
|
If you merge master it will run the CI (master was having problems yesterday) |
|
ok, ping on green. |
jhereth
force-pushed
the
15562_regression_test
branch
from
4c580c3 to
eb3a547
Compare
jhereth
force-pushed
the
15562_regression_test
branch
from
eb3a547 to
2fcf885
Compare
|
@jreback Tests are green |
mroeschke
approved these changes
Oct 19, 2019
|
thanks @qudade |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis change doesn't add a new feature but adds an regression test for #15562 which has been fixed with pandas 0.20. Hence there is no whatsnew entry.
The bug was reported for pandas 0.18.1 and persisted until 0.19.2 but was fixed in 0.20.0(-rc1). I managed to reproduce the error (with
numpy==1.12.1on python 3.6, otherwise some errors unrelated to this bug appear).I added an regression test to
pandas/tests/groupby/test_apply.pyand verified that the code will fail with 0.19.2 and succeed with 0.20.0 and master.I wasn't able to further reduce the test provided by @field-cady.