-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Improve compatibility with pypy error messages #28844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm I'm surprised pypy would impact these. Can you post pd.show_versions()? |
|
I suspect this is probably due to numpy versioning instead of pypy but in any case I think OK. @simonjayhawkins care to look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rlamy lgtm.
LGTM. Should we consider adding a CI build for pypy? |
There are lots of failures ATM, I want to fix more of them before suggesting adding it to CI. |
@rlamy yep, I'm seeing 750 failures and 35 errors. Some of those are mismatching exception messages like this PR, but I'm also seeing a lot of OverflowErrors. Are you involved with pypy? i.e. are you able/willing to help troubleshoot these? |
This fixes a bunch of spurious errors when running the test suite on pypy3.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff