Skip to content

fix unnecessary sort in pd.read_json and orient="index" #28606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 9, 2019
Merged

fix unnecessary sort in pd.read_json and orient="index" #28606

merged 13 commits into from
Oct 9, 2019

Conversation

KimDoubleB
Copy link
Contributor

@KimDoubleB KimDoubleB commented Sep 25, 2019 •
edited by WillAyd
Loading

jreback
jreback requested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised this doesn't break things

jreback
jreback requested changes Sep 25, 2019
View reviewed changes
@jreback jreback added Compat pandas objects compatability with Numpy or Python functions IO JSON read_json, to_json, json_normalize labels Sep 25, 2019
WillAyd
WillAyd requested changes Sep 25, 2019
View reviewed changes
WillAyd
WillAyd requested changes Sep 25, 2019
View reviewed changes
@WillAyd
Copy link
Member

WillAyd commented Oct 1, 2019

Looks simpler - nice job! Can you also add a whatsnew for v1.0.0?

@WillAyd WillAyd added this to the 1.0 milestone Oct 1, 2019
@KimDoubleB
Copy link
Contributor Author

Of course.

@WillAyd
Copy link
Member

WillAyd commented Oct 2, 2019

Looks like an isort failure is causing CI to go red, but outside of that this change lgtm

@WillAyd
Copy link
Member

WillAyd commented Oct 8, 2019

Looks like you still have an isort error. Can you run isort pandas/io/json/_json.py locally and push up the result?

WillAyd
WillAyd approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @jreback not sure if you have any other comments

@WillAyd WillAyd merged commit 93183ba into pandas-dev:master Oct 9, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 9, 2019

Thanks @KimDoubleB - great PR and congrats on first contribution!

@KimDoubleB
Copy link
Contributor Author

Thanks so much. @WillAyd
I’m really grateful for your help.

@KimDoubleB KimDoubleB deleted the sort branch October 11, 2019 04:12
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@KimDoubleB @proost
fix unnecessary sort in pd.read_json and orient="index" (pandas-dev#2…
581b552 
…8606)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@KimDoubleB @proost
fix unnecessary sort in pd.read_json and orient="index" (pandas-dev#2…
e754290 
…8606)
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@KimDoubleB
fix unnecessary sort in pd.read_json and orient="index" (pandas-dev#2…
db6e76a 
…8606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

pd.read_json and orient="index" sorts results
3 participants
@KimDoubleB @WillAyd @jreback