-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Clean up Abstract and Naming Definitions for GroupBy #28847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes sense. LGTM pending green |
thanks @WillAyd doc-strings would be very helpful on some of these as well :-> |
Agreed - docstrings and annotations should come in one of these |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
_iterate_slices
abstract in base class, moved pre-existing definition from Base -> Series where it was actually being called (DataFrame already overrides)_wrap_transformed_output
Abstract in base class, as both Series and DataFrame override this_wrap_applied_output
; this was Abstract in base class before but its definition was not in sync with how the subclasses actually defined_wrap_output
to_wrap_series_output
as it is only valid for SeriesGroupBy_wrap_generic_output
to_wrap_frame_output
as it is only valid for DataFrameGroupBy_aggregate_generic
to_aggregate_frame
as it is only valid for DataFrameGroupByMore to come in separate PRs