TST: Add a regression test for the timezone issue #29097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigoriosgiann
changed the title
simonjayhawkins
requested changes
Oct 19, 2019
| pd.Timestamp("2019-03-15 12:34:34.660000+0000", tz="UTC"), | ||
| ], | ||
| ) | ||
| df2 = df.apply(lambda x: x.name, axis=1) |
Comment on lines
373
to
374
| assert df[0].keys().dtype == df2.dtypes | ||
| assert (df[0].keys().values == df2.values).all() |
There was a problem hiding this comment.
construct the expected DataFrame explicitly and do tm.assert_frame_equals(result,expected)
simonjayhawkins
added
Apply
grigoriosgiann
force-pushed
the
test-dt-apply
branch
from
ec65243 to
7415fc6
Compare
|
Hello @grigoriosgiann! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-20 10:52:05 UTC |
grigoriosgiann
force-pushed
the
test-dt-apply
branch
from
7415fc6 to
3109dff
Compare
Thanks for the feedback! 😄 |
jreback
requested changes
Oct 19, 2019
| @@ -356,3 +356,17 @@ def test_loc_label_slicing(self): | |||
| expected = ser.iloc[:-1] | |||
|
|
|||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_apply_datetime_tz_issue(self): | |||
There was a problem hiding this comment.
looks good, can you move to pandas/tests/frame/test_apply.py
ping on green.
grigoriosgiann
force-pushed
the
test-dt-apply
branch
from
3109dff to
9b234b4
Compare
jreback
approved these changes
Oct 19, 2019
|
lgtm. ping on green. |
|
Azure appears to be stuck... Edit: Force re-pushed since azure failed after some time (https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=19252&view=logs) |
grigoriosgiann
force-pushed
the
test-dt-apply
branch
3 times, most recently
from
bd070d4 to
b528352
Compare
Add a regression test to ensure that the timezone doesn't get removed when using `df.apply`.
grigoriosgiann
force-pushed
the
test-dt-apply
branch
from
b528352 to
2ddda38
Compare
|
Ping, it's green!😄 |
|
thanks @grigoriosgiann |
RonKbS
added a commit
to RonKbS/pandas
that referenced
this pull request
Oct 20, 2019
Add a regression test for the timezone issue (pandas-dev#29097)
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 23, 2019
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a regression test to ensure that the timezone doesn't get removed
when using
df.apply.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff