Skip to content

TST: Fix not-boxed maybe_promote test #28852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 8, 2019

Along with #28833 this gets close to finishing off the not-boxed cases

@WillAyd WillAyd added Testing pandas testing functions or related to the test suite Dtype Conversions Unexpected or buggy dtype conversions and removed Testing pandas testing functions or related to the test suite labels Oct 8, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 8, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 8, 2019

lgtm

@jreback jreback merged commit 29e56df into pandas-dev:master Oct 8, 2019
@jreback
Copy link
Contributor

jreback commented Oct 8, 2019

thanks

@jbrockmendel jbrockmendel deleted the maybe_promote12 branch October 8, 2019 21:33
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants