BUG: Fix numpy boolean subtraction error in Series.diff #27755
Closed
+6,569
−4,136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy no longer allows subtraction of boolean values. Not sure if Numpy version checking should be done before this code...
Note: I haven't actually run this code, feel free to check it, but should be correct.
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-46-3da3b949c6bd> in <module>
1 data = pd.Series([0,-1,-2,-3,-4,-3,-2,-1,0,-1,-1,0,-1,-2,-3,-2,0])
2 filtered = data.between(-2,0, inclusive = True)
----> 3 filtered.diff()
4 print(filtered)
~\AppData\Local\Continuum\anaconda3\lib\site-packages\pandas\core\series.py in diff(self, periods)
2191 dtype: float64
2192 """
-> 2193 result = algorithms.diff(com.values_from_object(self), periods)
2194 return self._constructor(result, index=self.index).__finalize__(self)
2195
~\AppData\Local\Continuum\anaconda3\lib\site-packages\pandas\core\algorithms.py in diff(arr, n, axis)
1817 out_arr[res_indexer] = result
1818 else:
-> 1819 out_arr[res_indexer] = arr[res_indexer] - arr[lag_indexer]
1820
1821 if is_timedelta:
TypeError: numpy boolean subtract, the `-` operator, is deprecated, use the bitwise_xor, the `^` operator, or the logical_xor function instead.
jreback
requested changes
Aug 5, 2019
|
Hello @Unprocessable! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-10 23:56:48 UTC |
|
Are there other tests for diff? If so they should be collected here or this should join them. |
* BUG: fix to_datetime(dti, utc=True) * whatsnew, suggested edits * parametrize * backquotes
Unprocessable
changed the title
I copied the data over to the other file, diff tests should be in one file and the boolean test cannot be added to this one as it is not a time series.
jreback
requested changes
Aug 6, 2019
pandas/tests/series/test_diff.py
Outdated
| result, Series(TimedeltaIndex(["NaT"] + ["1 days"] * 4), name="foo") | ||
| ) | ||
|
|
||
| # boolean series |
There was a problem hiding this comment.
Can you add a test for a mix of bool & NA? pd.Series([True, False, np.nan, False], dtype="object')
pandas-dev#28158) * CLN: Use ABC classes for isinstance checks, remove unnecessary imports * Formatting repairs
…-dev#28182) * Add example for adding a calculated column
* REGR: Fix to_csv with IntervalIndex
* add isort:skip to "from .pandas_vb_common import setup" * add isort:skip to noqa: E402 marked lines * run black * add noqa: E402 isort:skip where needed * run pre-commit filters on asv_bench/benchmarks/ * parse the isort config when using pre-commit * run isort on pandas/core/api.py * run pre-commit filters and commit trivial import sorting changes * specify flake8 errors in pandas/io/msgpack/__init__.py * fix imports for doc/source/conf.py * fix the [isort] skip entry in setup.cfg Also I removed the files for which I have fixed the problems.
…dev#28216) * REGR: <th> tags for notebook display closes pandas-dev#28204
…das-dev#11886 (pandas-dev#26795) * DOC: add single dtype to NDFrame.to_sql
* CLN: catch less inside try/except
5 tasks
|
superseded by #28251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27755, for more than three years now NumPy has not allowed the subtraction of boolean series.
TypeError Traceback (most recent call last)
in
1 data = pd.Series([0,-1,-2,-3,-4,-3,-2,-1,0,-1,-1,0,-1,-2,-3,-2,0])
2 filtered = data.between(-2,0, inclusive = True)
----> 3 filtered.diff()
4 print(filtered)
~\AppData\Local\Continuum\anaconda3\lib\site-packages\pandas\core\series.py in diff(self, periods)
2191 dtype: float64
2192 """
-> 2193 result = algorithms.diff(com.values_from_object(self), periods)
2194 return self._constructor(result, index=self.index).finalize(self)
2195
~\AppData\Local\Continuum\anaconda3\lib\site-packages\pandas\core\algorithms.py in diff(arr, n, axis)
1817 out_arr[res_indexer] = result
1818 else:
-> 1819 out_arr[res_indexer] = arr[res_indexer] - arr[lag_indexer]
1820
1821 if is_timedelta:
TypeError: numpy boolean subtract, the
-operator, is deprecated, use the bitwise_xor, the^operator, or the logical_xor function instead.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff