TYPING: change to FrameOrSeries Alias in pandas._typing #28173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Aug 27, 2019
| Scalar = Union[str, int, float] | ||
| Axis = Union[str, int] | ||
| Ordered = Optional[bool] | ||
| _T = TypeVar("_T") |
There was a problem hiding this comment.
Can you just add a quick inline comment for the purpose of this one? May be useful for those who haven't invested a lot of time in annotations yet
There was a problem hiding this comment.
something like
# Unconstrained type variable for generic functions and user-defined generic types.
# see https://docs.python.org/3/library/typing.html#generics and
# https://docs.python.org/3/library/typing.html#typing.TypeVar for more info.
There was a problem hiding this comment.
Ideally less technical. Maybe something like # to maintain type information across generic functions and parametrization or even slightly less technical if possible
|
Thanks @simonjayhawkins |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #27646 (review)
cc @WillAyd