CLN: Use ABC classes for isinstance checks, remove unnecessary imports #28158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR! Any idea for how many more there might be? |
|
There are a large number of additional isinstance checks which could be changed (40-50 in the files that came up in your script), but I'm not sure how many of them will allow removal of the child imports -- thus won't update those per @jbrockmendel's benchmark. I'll keep digging for more which do allow import removals...do you want me to add any additional to this PR or open separate? May not get it all done at once. |
|
I'm OK with doing it incrementally in separate PRs. Just ultimately want to make sure we have an end in sight. However you feel best to manage that works! |
|
@jbrockmendel thoughts here? Merge if happy |
|
Thanks @addisonlynch |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
pandas-dev#28158) * CLN: Use ABC classes for isinstance checks, remove unnecessary imports * Formatting repairs
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
pandas-dev#28158) * CLN: Use ABC classes for isinstance checks, remove unnecessary imports * Formatting repairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #27353 changed
isinstancechecks listed in the @WillAyd script to use ABCs where it enabled removal of imports only.Note there may be additional files which can be cleaned as the script does not parse multi-line statements.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff