Skip to content

Fix slicer assignment bug #28131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2019
Merged

Fix slicer assignment bug #28131

merged 5 commits into from
Aug 28, 2019

Conversation

RoeiRaz
Copy link
Contributor

@RoeiRaz RoeiRaz commented Aug 25, 2019 •
edited
Loading

@simonjayhawkins simonjayhawkins added the Indexing Related to indexing on series/frames, not to indexes themselves label Aug 25, 2019
TomAugspurger
TomAugspurger reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a release note in 1.0.0?

Are there any issues with negative steps other than -1, or is the adjustment to start and stop correct for all negative steps?

@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 28, 2019
@jbrockmendel
Copy link
Member

LGTM

@WillAyd WillAyd merged commit bc65fe6 into pandas-dev:master Aug 28, 2019
@WillAyd
Copy link
Member

WillAyd commented Aug 28, 2019

Nice PR - thanks @RoeiRaz !

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@RoeiRaz @proost
Fix slicer assignment bug (pandas-dev#28131)
5ffa66f
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@RoeiRaz @proost
Fix slicer assignment bug (pandas-dev#28131)
05c8daf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@WillAyd WillAyd WillAyd approved these changes

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

BUG: cannot set Series with reverse slicer
5 participants
@RoeiRaz @jbrockmendel @WillAyd @TomAugspurger @simonjayhawkins