Skip to content

STY: whitespace before class docstringsd #28209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2019
Merged

STY: whitespace before class docstringsd #28209

merged 1 commit into from
Aug 29, 2019

Conversation

jbrockmendel
Copy link
Member

all occurrences of 'class.*:\n\n( )+"""'

@datapythonista would it make sense to add this to the checks or docstring validation?

@datapythonista datapythonista added the Code Style Code style, linting, code_checks label Aug 29, 2019
datapythonista
datapythonista approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, will be good to have this standardized.

+1 on adding it to the checks. Not sure if flake8 can take care of this, it should, but with your regex is also good.

Let me take care of adding it to the checks, the task is perfect for the people I'm mentoring.

@datapythonista datapythonista mentioned this pull request Aug 29, 2019
Open
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Aug 29, 2019
@simonjayhawkins simonjayhawkins merged commit 2518040 into pandas-dev:master Aug 29, 2019
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the dstrs branch August 29, 2019 13:57
@Ayowolet Ayowolet mentioned this pull request Sep 18, 2019
Merged
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
STY: whitespace before class docstringsd (pandas-dev#28209)
1034b7e
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
STY: whitespace before class docstringsd (pandas-dev#28209)
7adc861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @simonjayhawkins @datapythonista