-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REGR: <th> tags for notebook display closes #28204 #28216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
not added whatsnew. target 0.25.2? |
Was it a regression in 0.25 or earlier? |
haven't checked thoroughly but i think the bug was introduced in 0.25.1 #27991 |
With 0.25.0 In [2]: df = pd.DataFrame({"a": 1}, index=pd.MultiIndex.from_product([['a'], [2, 3]]))
In [3]: print(df._repr_html_()) <div>
<style scoped>
.dataframe tbody tr th:only-of-type {
vertical-align: middle;
}
.dataframe tbody tr th {
vertical-align: top;
}
.dataframe thead th {
text-align: right;
}
</style>
<table border="1" class="dataframe">
<thead>
<tr style="text-align: right;">
<th></th>
<th></th>
<th>a</th>
</tr>
</thead>
<tbody>
<tr>
<th rowspan="2" valign="top">a</th>
<th>2</th>
<td>1</td>
</tr>
<tr>
<th>3</th>
<td>1</td>
</tr>
</tbody>
</table>
</div> and with 0.25.1 In [3]: print(df._repr_html_())
<div>
<style scoped>
.dataframe tbody tr th:only-of-type {
vertical-align: middle;
}
.dataframe tbody tr th {
vertical-align: top;
}
.dataframe thead th {
text-align: right;
}
</style>
<table border="1" class="dataframe">
<thead>
<tr style="text-align: right;">
<th></th>
<th></th>
<th>a</th>
</tr>
</thead>
<tbody>
<tr>
<td rowspan="2" valign="top">a</td>
<td>2</td>
<td>1</td>
</tr>
<tr>
<td>3</td>
<td>1</td>
</tr>
</tbody>
</table>
</div> So it seems to have been a 0.25.1 regression (so target for 0.25.2) |
thanks @TomAugspurger . will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge conflict in the release notes.
…dev#28216) * REGR: <th> tags for notebook display closes pandas-dev#28204
…dev#28216) * REGR: <th> tags for notebook display closes pandas-dev#28204
…dev#28216) * REGR: <th> tags for notebook display closes pandas-dev#28204
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff