CLN: internals.blocks cleanup, typing #27941
Conversation
pandas/core/internals/blocks.py
Outdated
| @@ -669,7 +669,7 @@ def convert( | |||
|
|
|||
| return self.copy() if copy else self | |||
|
|
|||
| def _can_hold_element(self, element): | |||
| def _can_hold_element(self, element) -> bool: | |||
There was a problem hiding this comment.
element here should be Any right? If so I think OK to type as an explicit indication
There was a problem hiding this comment.
Note this comment is applicable in a lot of the signatures here
pandas/core/internals/blocks.py
Outdated
| @@ -1288,7 +1276,7 @@ def take_nd(self, indexer, axis, new_mgr_locs=None, fill_tuple=None): | |||
| else: | |||
| return self.make_block_same_class(new_values, new_mgr_locs) | |||
|
|
|||
| def diff(self, n, axis=1): | |||
| def diff(self, n: int, axis: int = 1): | |||
There was a problem hiding this comment.
I think can type the return as -> "Block" here
There was a problem hiding this comment.
Think this would still be nice as a follow up or another commit
There was a problem hiding this comment.
is using a string here the best practice?
Good to have you back
There was a problem hiding this comment.
Thanks! And yea you would want to use a string literal when the return type for a function is a type of the class itself
Mypy and related documentation will refer to this as a forward reference
|
Thanks @jbrockmendel |
No description provided.