Skip to content

[$45] Clear previous filtering cache on Listings page #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oanh-and-only-Oanh opened this issue Sep 8, 2020 · 16 comments
Closed

[$45] Clear previous filtering cache on Listings page #4874

Oanh-and-only-Oanh opened this issue Sep 8, 2020 · 16 comments
Assignees
@rashmi73
Labels
Challenge Listing QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone
v1.2.1

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Sep 8, 2020 •
edited by SathyaJayabal
Loading

Issues: Currently, the user's previous filter settings are persistent/saved so when they visit topcoder.com/challenges in the future, their filters are saved. This causes confusion because it may show "no active challenges available".

#3607 - Remove feature added by this ticket

Expected behavior: clear member's search filters when they visit www.topcoder.com/challenges.
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Clear previous filtering cache on Listings page [$45] Clear previous filtering cache on Listings page Sep 8, 2020
@Oanh-and-only-Oanh
Copy link
Author

@SathyaJayabal, the current UX of automatically cashing user's last filter settings is confusing.

@crazyk07
Copy link

crazyk07 commented Sep 8, 2020

Contest https://www.topcoder.com/challenges/30141035 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/milestone-20200917
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-20200917

run npm run test before PR

@rashmi73 rashmi73 self-assigned this Sep 8, 2020
@crazyk07
Copy link

crazyk07 commented Sep 8, 2020

Contest https://www.topcoder.com/challenges/30141035 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@rashmi73
Copy link
Contributor

rashmi73 commented Sep 8, 2020

@luizrrodrigues can you please provide exact steps? as link mentioned in issue descrption is of different issue. waiting

@SathyaJayabal
Copy link
Collaborator

@rashmi73 , please see updated description. The tracks selection was being saved for the user. But this feature must be removed and every time the user access the listings page, all filters must be cleared.
cc @Oanh-and-only-Oanh

@luizrrodrigues
Copy link
Collaborator

Thanks @SathyaJayabal

@luizrrodrigues
Copy link
Collaborator

@rashmi73 Any progress on this one?

@rashmi73
Copy link
Contributor

rashmi73 commented Sep 9, 2020

@luizrrodrigues yes actively on it sometime required

@rashmi73
Copy link
Contributor

rashmi73 commented Sep 9, 2020

@luizrrodrigues PR #4882

@luizrrodrigues
Copy link
Collaborator

@rashmi73 Check feedback here: #4882 (review)

@rashmi73
Copy link
Contributor

@luizrrodrigues updated PR

@sandhiyakavi
Copy link
Collaborator

Verified on Staging.

#4874.zip

@luizrrodrigues luizrrodrigues mentioned this issue Sep 15, 2020
Merged
@sandhiyakavi sandhiyakavi modified the milestones: By 9/17/2020, v1.2.1 Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on staging
4874.mov.zip

@luizrrodrigues luizrrodrigues mentioned this issue Sep 15, 2020
Merged
sushilshinde added a commit that referenced this issue Sep 15, 2020
@sushilshinde
release: v1.2.1
27118ee 
Title: Bug-fixes : v5 integration, cotentful, etc( Release - v1.2.1) (sushil)
Service & Impact Area: Community App
Expected Outcome: Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Work plan: Issues: #2069 #4874 #4898 #4347 #4745 #4895 #4687 #4910 #4896 #4889 #4888 #4887 #4912
PR: #4923
DEPENDENCY: topcoder-react-lib
- Issue: #2069
- PR: topcoder-platform/topcoder-react-lib#253
DEPENDENCY: topcoder-react-ui-kit
- Issue: #4745
- PR: topcoder-archive/topcoder-platform-topcoder-react-ui-kit#35
Team: luiz/picachui/sandhiya/kiril/sushil
Date and Timing: Tue 15 Sept 2020, 4.00 PM
Testing (what will be tested): Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Rollback Plan: Revert PR
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production tcx_FixAccepted and removed QA Pass in Staging labels Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
clear filter.mov.zip

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30141035

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rashmi73 rashmi73

Labels
Challenge Listing QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
v1.2.1
Development

No branches or pull requests
6 participants
@luizrrodrigues @rashmi73 @crazyk07 @Oanh-and-only-Oanh @sandhiyakavi @SathyaJayabal