Skip to content

[$40] Open Blog page on separate tab #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oanh-and-only-Oanh opened this issue May 5, 2020 · 9 comments
Closed

[$40] Open Blog page on separate tab #4347

Oanh-and-only-Oanh opened this issue May 5, 2020 · 9 comments
Assignees
@gets0ul
Labels
Navigation P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone
v1.2.1

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented May 5, 2020 •
edited
Loading

When user clicks on BLOG on the navigation menu, open page in separate tab.

image
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the Release by 10/1/2020 milestone Sep 8, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh mentioned this issue Sep 10, 2020
Closed
@Oanh-and-only-Oanh Oanh-and-only-Oanh added P3 Normal (resolved within 7 days) and removed hot-fix labels Sep 10, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Open Blog page on separate tab [$35] Open Blog page on separate tab Sep 10, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title [$35] Open Blog page on separate tab [$40] Open Blog page on separate tab Sep 11, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30141467 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@gets0ul gets0ul self-assigned this Sep 11, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30141467 has been updated - it has been assigned to gets0ul.

This is an automated message for crazyk via Topcoder X

@gets0ul
Copy link
Collaborator

gets0ul commented Sep 11, 2020

Which branch to use?

@Oanh-and-only-Oanh
Copy link
Author

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/milestone-20200924
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-20200924

@Oanh-and-only-Oanh
Copy link
Author

run npm run test before PR

@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: Release by 10/1/2020, By 9/24/2020 Sep 11, 2020
gets0ul added a commit to gets0ul/community-app that referenced this issue Sep 11, 2020
@gets0ul
Fix for topcoder-platform#4347 - Open blog page in new, separate tab
b46b000
@gets0ul gets0ul mentioned this issue Sep 11, 2020
Merged
luizrrodrigues added a commit that referenced this issue Sep 13, 2020
@luizrrodrigues
Merge pull request #4900 from gets0ul/issue-4347
48d1bf5 
Fix for #4347 - Open blog page in new, separate tab
luizrrodrigues added a commit that referenced this issue Sep 14, 2020
@luizrrodrigues
Deploy milestone-20200924 to Dev and Stag
22a2677 
Issues: #4347 #4745 #4895 #4687
@SathyaJayabal
Copy link
Collaborator

verified
4347.mov.zip

@luizrrodrigues luizrrodrigues mentioned this issue Sep 15, 2020
Merged
@sandhiyakavi sandhiyakavi modified the milestones: By 9/24/2020, v1.2.1 Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on staging (develop)
4347.mov 2.zip

@luizrrodrigues luizrrodrigues mentioned this issue Sep 15, 2020
Merged
sushilshinde added a commit that referenced this issue Sep 15, 2020
@sushilshinde
release: v1.2.1
27118ee 
Title: Bug-fixes : v5 integration, cotentful, etc( Release - v1.2.1) (sushil)
Service & Impact Area: Community App
Expected Outcome: Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Work plan: Issues: #2069 #4874 #4898 #4347 #4745 #4895 #4687 #4910 #4896 #4889 #4888 #4887 #4912
PR: #4923
DEPENDENCY: topcoder-react-lib
- Issue: #2069
- PR: topcoder-platform/topcoder-react-lib#253
DEPENDENCY: topcoder-react-ui-kit
- Issue: #4745
- PR: topcoder-archive/topcoder-platform-topcoder-react-ui-kit#35
Team: luiz/picachui/sandhiya/kiril/sushil
Date and Timing: Tue 15 Sept 2020, 4.00 PM
Testing (what will be tested): Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Rollback Plan: Revert PR
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production tcx_FixAccepted and removed QA Pass in Staging labels Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
blog link.mov.zip

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30141467

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gets0ul gets0ul

Labels
Navigation P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
v1.2.1
Development

No branches or pull requests
6 participants
@gets0ul @luizrrodrigues @crazyk07 @Oanh-and-only-Oanh @sandhiyakavi @SathyaJayabal