Skip to content

[$40] Public Profile: Past MARATHON MATCH challenges are not shown #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codejamtc opened this issue Mar 15, 2019 · 29 comments
Closed

[$40] Public Profile: Past MARATHON MATCH challenges are not shown #2069

codejamtc opened this issue Mar 15, 2019 · 29 comments
Assignees
Labels
Bug Bash Issues going in next bug bash Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone

Comments

@codejamtc
Copy link
Collaborator

image

  1. Open the application and login as TonyJ
  2. Go to https://www.topcoder-dev.com/members/Egor/details/?track=DATA_SCIENCE&subTrack=MARATHON_MATCH&tab=statistics
  3. Click Challenges

Actual: Past MARATHON MATCH challenges are not shown

Expected: Should show the Past MM

Reproducibility Rate: 3/3

Environment: HP Pavilion x360 14 inch; Windows 10 | Browser: Google Chrome 73.0.3683.75

@ThomasKranitsas
Copy link
Contributor

@sushilshinde @skyhit API issue?

@codejamtc
Copy link
Collaborator Author

codejamtc commented Mar 17, 2019

https://www.topcoder.com/members/tourist/details/?track=DATA_SCIENCE&subTrack=MARATHON_MATCH&tab=statistics

main-1552462291728.js:65 Uncaught (in promise) TypeError: M.getUserMarathonMatches is not a function
    at main-1552462291728.js:65
    at m (main-1552462291728.js:57)
    at Generator._invoke (main-1552462291728.js:57)
    at Generator.e.(anonymous function) [as next] (https://d2nl5eqipnb33q.cloudfront.net/static-assets/main-1552462291728.js:57:35904)
    at o (main-1552462291728.js:9)
    at main-1552462291728.js:9
    at new Promise (<anonymous>)
    at new t (main-1552462291728.js:9)
    at main-1552462291728.js:9
    at main-1552462291728.js:65
    at O.o (main-1552462291728.js:9)
    at Object.b [as getUserMarathonDone] (main-1552462291728.js:9)
    at loadMarathon (chunk-1552462291728.js:1)
    at t.value (chunk-1552462291728.js:1)
    at Ep (main-1552462291728.js:86)
    at Xp (main-1552462291728.js:86)
    at Bp (main-1552462291728.js:86)
    at vp (main-1552462291728.js:86)
    at Za (main-1552462291728.js:86)
    at Object.enqueueSetState (main-1552462291728.js:86)
    at n.m.setState (main-1552462291728.js:65)
    at main-1552462291728.js:70
(anonymous) @ main-1552462291728.js:65
m @ main-1552462291728.js:57
(anonymous) @ main-1552462291728.js:57
e.(anonymous function) @ main-1552462291728.js:57
o @ main-1552462291728.js:9
(anonymous) @ main-1552462291728.js:9
t @ main-1552462291728.js:9
(anonymous) @ main-1552462291728.js:9
(anonymous) @ main-1552462291728.js:65
O.o @ main-1552462291728.js:9
b @ main-1552462291728.js:9
loadMarathon @ chunk-1552462291728.js:1
value @ chunk-1552462291728.js:1
Ep @ main-1552462291728.js:86
Xp @ main-1552462291728.js:86
Bp @ main-1552462291728.js:86
vp @ main-1552462291728.js:86
Za @ main-1552462291728.js:86
enqueueSetState @ main-1552462291728.js:86
m.setState @ main-1552462291728.js:65
(anonymous) @ main-1552462291728.js:70

@nithyaasworld nithyaasworld added P1 Urgent (resolve within 24 hours) P2 Important (resolve within 3 days) and removed Blocker P1 Urgent (resolve within 24 hours) labels Jun 12, 2019
@nithyaasworld
Copy link
Collaborator

This is still an issue:

image

@veshu veshu added the Bug Bash Issues going in next bug bash label Aug 27, 2019
@veshu veshu added this to the PD Defects Fixes Challenge 1 milestone Aug 27, 2019
@veshu veshu changed the title Public Profile: Past MARATHON MATCH challenges are not shown [$40]Public Profile: Past MARATHON MATCH challenges are not shown Aug 27, 2019
@crazyk07
Copy link

[400]: Failed to create challenge. Detail: Operation failed in the contest service facade.

This is an automated message for crazyk via Topcoder X

1 similar comment
@crazyk07
Copy link

[400]: Failed to create challenge. Detail: Operation failed in the contest service facade.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30100383 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30100383 has been updated - the new changes has been updated for this ticket.

This is an automated message for crazyk via Topcoder X

@SathyaJayabal SathyaJayabal removed this from the PD Defects Fixes Challenge 1 milestone May 7, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added P1 Urgent (resolve within 24 hours) Member Profiles and removed P2 Important (resolve within 3 days) labels Sep 3, 2020
@Oanh-and-only-Oanh
Copy link

@luizrrodrigues, can you please open this ticket up for pick up. thanks

@crazyk07
Copy link

crazyk07 commented Sep 3, 2020

Contest https://www.topcoder.com/challenges/30100383 has been updated - jcori has been unassigned.

This is an automated message for crazyk via Topcoder X

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title [$40]Public Profile: Past MARATHON MATCH challenges are not shown Public Profile: Past MARATHON MATCH challenges are not shown Sep 3, 2020
@rootelement
Copy link
Contributor

As a start, this Challenges page is making an invalid call to v5:
https://api.topcoder-dev.com/v5/challenges?status=PAST&isRatedForMM=true&tag=Marathon%20Match&memberId=Egor

Please refer to the swagger for the appropriate call. I believe this should look like this:
https://api.topcoder-dev.com/v5/challenges?status=Completed&tags[]=Marathon%20Match&memberId=14970299

or
https://api.topcoder-dev.com/v5/challenges?status=Completed&tracks[]=DS&types[]=CH&tags[]=Marathon%20Match&memberId=14970299

However, this also requires the legacy marathon matches to be migrated, which is being tracked in this issue:
topcoder-platform/challenge-api#288

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 14, 2020

@luizrrodrigues , verified challenge link.

Also the "Sorry, No challenges are found" message is displayed before the challenges load.
2069.mov.zip

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Fixed, ready for QA

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , verified, Thank you.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 15, 2020

verified on staging. Points details to be tracked in #4527
Screenshot 2020-09-15 at 10 52 48 AM

sushilshinde added a commit that referenced this issue Sep 15, 2020
Title: Bug-fixes : v5 integration, cotentful, etc( Release - v1.2.1) (sushil)
Service & Impact Area: Community App
Expected Outcome: Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Work plan: Issues: #2069 #4874 #4898 #4347 #4745 #4895 #4687 #4910 #4896 #4889 #4888 #4887 #4912
PR: #4923
DEPENDENCY: topcoder-react-lib
- Issue: #2069
- PR: topcoder-platform/topcoder-react-lib#253
DEPENDENCY: topcoder-react-ui-kit
- Issue: #4745
- PR: topcoder-archive/topcoder-platform-topcoder-react-ui-kit#35
Team: luiz/picachui/sandhiya/kiril/sushil
Date and Timing: Tue 15 Sept 2020, 4.00 PM
Testing (what will be tested): Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Rollback Plan: Revert PR
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production tcx_FixAccepted and removed QA Pass in Staging labels Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-09-15 at 4 27 39 PM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30100383

This is an automated message for crazyk via Topcoder X

@ajefts
Copy link
Member

ajefts commented Sep 15, 2020

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I'll check (Weird I was testing this user when reviewing the fix)

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 15, 2020

@luizrrodrigues , tracking it here #4926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bash Issues going in next bug bash Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Development

No branches or pull requests