Skip to content

OG meta tags for Thrive pages #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Sep 10, 2020 · 5 comments
Closed

OG meta tags for Thrive pages #4887

kkartunov opened this issue Sep 10, 2020 · 5 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production Test Env Environment
Milestone
v1.2.1

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented Sep 10, 2020 •
edited
Loading

Should be fixed:
Article page:

  • title
  • description
  • og:title
  • og:image
  • og:description
  • twitter:description
  • twitter:image

Home page/Search page/Track page:

  • title
  • description
  • og:title
  • og:description
  • twitter:description
@kkartunov kkartunov self-assigned this Sep 10, 2020
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Sep 10, 2020
kkartunov added a commit that referenced this issue Sep 14, 2020
@kkartunov
Fixes for #4887
227c600
@kkartunov kkartunov mentioned this issue Sep 14, 2020
Merged
@kkartunov kkartunov added this to the By 9/15/2020 milestone Sep 14, 2020
@SathyaJayabal SathyaJayabal modified the milestones: By 9/15/2020, By 9/17/2020 Sep 14, 2020
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 14, 2020 •
edited
Loading

@kkartunov , I don't find the below meta tags

Article page:
title
Home page/Search page/Track page:
title

Screenshot 2020-09-14 at 6 45 17 PM

Screenshot 2020-09-14 at 6 45 45 PM

@SathyaJayabal SathyaJayabal added Need clarification Need clarification to proceed fixing the issue further and removed Ready for QA labels Sep 14, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal title is the <title> in head.

@SathyaJayabal
Copy link
Collaborator

oh ok :)

@SathyaJayabal SathyaJayabal added QA Pass and removed Need clarification Need clarification to proceed fixing the issue further labels Sep 14, 2020
@luizrrodrigues luizrrodrigues mentioned this issue Sep 14, 2020
Merged
@sandhiyakavi sandhiyakavi modified the milestones: By 9/17/2020, v1.2.1 Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on staging (develop)
Screenshot 2020-09-15 at 11 43 27 AM
Screenshot 2020-09-15 at 11 44 29 AM

@luizrrodrigues luizrrodrigues mentioned this issue Sep 15, 2020
Merged
sushilshinde added a commit that referenced this issue Sep 15, 2020
@sushilshinde
release: v1.2.1
27118ee 
Title: Bug-fixes : v5 integration, cotentful, etc( Release - v1.2.1) (sushil)
Service & Impact Area: Community App
Expected Outcome: Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Work plan: Issues: #2069 #4874 #4898 #4347 #4745 #4895 #4687 #4910 #4896 #4889 #4888 #4887 #4912
PR: #4923
DEPENDENCY: topcoder-react-lib
- Issue: #2069
- PR: topcoder-platform/topcoder-react-lib#253
DEPENDENCY: topcoder-react-ui-kit
- Issue: #4745
- PR: topcoder-archive/topcoder-platform-topcoder-react-ui-kit#35
Team: luiz/picachui/sandhiya/kiril/sushil
Date and Timing: Tue 15 Sept 2020, 4.00 PM
Testing (what will be tested): Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Rollback Plan: Revert PR
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-09-15 at 4 55 53 PM
Screenshot 2020-09-15 at 4 56 24 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production Test Env Environment
Projects
None yet
Milestone
v1.2.1
Development

No branches or pull requests
3 participants
@kkartunov @sandhiyakavi @SathyaJayabal